pylint fixes

google · Oct 12, 2023 · c87a477 · c87a477
1 parent 99c8e20
commit c87a477
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/tools/abel/model/guid_to_entity_map.py b/tools/abel/model/guid_to_entity_map.py
@@ -67,7 +67,7 @@ def AddEntity(self, entity: ...) -> None:
       raise ValueError('Cannot add None values to the guid to entity map.')
     elif not entity.bc_guid:
       raise AttributeError(f'{entity.code}: guid missing')
-    elif entity.bc_guid not in list(self._guid_to_entity_map.keys()):
+    elif entity.bc_guid not in list(self._guid_to_entity_map):
       self._guid_to_entity_map[entity.bc_guid] = entity
     elif self._guid_to_entity_map.get(entity.bc_guid) == entity:
       # Do nothing, this mapping already exists

diff --git a/tools/abel/tests/entity_field_test.py b/tools/abel/tests/entity_field_test.py
@@ -93,6 +93,7 @@ def testMissingFieldInequality(self):
   def testMissingFieldEqualityRaisesTypeError(self):
     test_missing_field = MissingField.FromDict(TEST_MISSING_FIELD_DICT)
 
+    # pylint: disable=unnecessary-dunder-call
     with self.assertRaises(TypeError):
       test_missing_field.__eq__('not a field')