Merge pull request #1426 from pranay2811/chw/cw-valve

Added CHW/CW bypass valves
google · Sep 25, 2024 · 1450e02 · 1450e02
2 parents 0a5b1c8 + 10e963c
commit 1450e02
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
@@ -4189,6 +4189,7 @@ CHWBZC:
   - failed_zone_air_temperature_alarm
   - high_zone_air_temperature_alarm
   - low_zone_air_temperature_alarm
+  - chilled_water_valve_status
 
 CHWBYPVPM:
   guid: "68cd5104-bf2e-48f3-8b88-c12192509393"
@@ -4202,6 +4203,16 @@ CHWBYPVPM:
   implements:
   - MONITORING
 
+CHWBYPVBC:
+  guid: "38064bbf-cd53-430d-af16-bf77d7e565a1"
+  description: "Chilled water bypass valve binary (open/closed) control."
+  is_abstract: true
+  implements: 
+  - OPERATIONAL
+  uses:
+  - chilled_water_bypass_valve_command
+  - chilled_water_bypass_valve_status
+
 MXVPM:
   guid: "4bb25777-d661-4fd3-9f8f-a84b349ada87"
   description: "Mixing valve percent monitoring."
@@ -8165,6 +8176,16 @@ CWBYPVPM:
   implements:
   - MONITORING
 
+CWBYPVBC:
+  guid: "2cf8239f-7da4-4df7-8125-8f70e5962def"
+  description: "Condensing water bypass valve binary (open/closed) control."
+  is_abstract: true
+  implements: 
+  - OPERATIONAL
+  uses:
+  - condensing_water_bypass_valve_command
+  - condensing_water_bypass_valve_status
+
 HWBYPVPM:
   guid: "38b01712-d458-4e5c-bf41-71107ebe8ecd"
   description: "Heating water bypass valve percentage monitoring."

diff --git a/ontology/yaml/resources/fields/telemetry_fields.yaml b/ontology/yaml/resources/fields/telemetry_fields.yaml
@@ -75,6 +75,12 @@ literals:
 - chilled_water_bypass_valve_percentage_sensor:
     fixed_min: 0.0
     fixed_max: 100.0
+- chilled_water_bypass_valve_command:
+  - OPEN
+  - CLOSED
+- chilled_water_bypass_valve_status:
+  - OPEN
+  - CLOSED
 - chilled_water_differential_pressure_sensor:
     flexible_min: -34473.78945
     flexible_max: 344737.8945
@@ -882,6 +888,9 @@ literals:
 - chilled_water_valve_command:
   - OPEN
   - CLOSED
+- chilled_water_valve_status:
+  - OPEN
+  - CLOSED
 - heating_percentage_command:
     fixed_min: 0.0
     fixed_max: 100.0
@@ -1313,6 +1322,12 @@ literals:
 - condensing_water_valve_percentage_command:
     fixed_min: 0.0
     fixed_max: 100.0
+- condensing_water_bypass_valve_command:
+  - OPEN
+  - CLOSED
+- condensing_water_bypass_valve_status:
+  - OPEN
+  - CLOSED
 
 - heater_run_status:
   - ON