For main functions returning a Future, translate into JS Promises when creating an npm package #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
Oct 29, 2020
nex3
reviewed
Nov 2, 2020
|
You'll need to merge with master to fix the build error, and you'll need to bump the pubspec to 1.1.0 and add a changelog entry. (I'd do this myself but it looks like you've disabled allowing me to push to your PR branch.) |
|
Sorry, I've been busy for a bit - I am not sure if this is considered a breaking change (and so would be v2.0.0) |
nex3
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #50 and enables proper error reporting in rules_sass in worker mode (bazelbuild/rules_sass#96).
I am not entirely sure if this warrants a particular unit test, given that this is basically a private API.