Skip to content

Commit

Permalink
Enable GitHub actions for Windows.
Browse files Browse the repository at this point in the history
Also added skip and a warning for using Beam on windows related to:
#32

PiperOrigin-RevId: 647445493
  • Loading branch information
evan-gordon authored and copybara-github committed Jun 27, 2024
1 parent fb90240 commit 50a1cea
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/go_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macOS-latest] # add windows once fully supported
os: [ubuntu-latest, macOS-latest, windows-latest]
steps:

- name: Set up Go 1.22
Expand Down
4 changes: 4 additions & 0 deletions beam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ for more information on Apache Beam.
**Warning: When using these tools with protected health information (PHI),
please be sure to follow your organization's policies with respect to PHI.**

**Note: There's currently an issue with Beam tests on Windows. Until this is
resolved it is not advised to use the beam job on Windows. See
https://github.com/google/cql/issues/32 for further context.**

## Running

The CQL on Beam pipeline is currently limited to local file system IO. The
Expand Down
6 changes: 6 additions & 0 deletions beam/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"fmt"
"os"
"path/filepath"
"runtime"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -117,6 +118,11 @@ func TestPipeline(t *testing.T) {
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
if runtime.GOOS == "windows" {
// https://github.com/google/cql/issues/32
// For some reason the bundle file is not being closed properly on Windows.
t.Skip("Skipping test on Windows due to io error")
}
p, s := beam.NewPipelineWithRoot()
result, errors := buildPipeline(s, test.cfg)
beam.ParDo0(s, diffEvalResults, beam.Impulse(s), beam.SideInput{Input: beam.CreateList(s, test.wantOutput)}, beam.SideInput{Input: result})
Expand Down

0 comments on commit 50a1cea

Please sign in to comment.