Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the select! example #2154

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Simplify the select! example #2154

merged 1 commit into from
Aug 9, 2024

Conversation

djmitche
Copy link
Collaborator

@mgeisler PTAL, as I believe you were the one to suggest this change in #1536.

This leaves some detail about select! out, but that might be just as well. Some of that detail is addressed in the pin! pitfall, later.

@djmitche djmitche requested a review from mgeisler June 20, 2024 20:56
mgeisler
mgeisler approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this a lot! More to the point and much easier for students to keep in their head. Thanks!

@djmitche djmitche merged commit 76857d7 into google:main Aug 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djmitche @mgeisler