-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 4564 and 4528 #4568
Merged
Merged
Revert 4564 and 4528 #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
force-pushed
the
chore/revert-4564
branch
from
December 28, 2024 14:55
1fba313
to
e24ca44
Compare
vitorguidi
added a commit
that referenced
this pull request
Dec 28, 2024
#4568 resolved the merge conflict on get_batch_regions incorrectly, this PR fixes that. Testing: ran schedule-fuzz locally to completion
lgtm Fascinating, I think we're not doing proper error reporitng in k8s https://pantheon.corp.google.com/errors;filter=%5B%5D?project=clusterfuzz-external&e=-13802955&mods=logs_tg_prod look |
jonathanmetzman
added a commit
that referenced
this pull request
Dec 30, 2024
This reverts commit 126d1c5.
jonathanmetzman
added a commit
that referenced
this pull request
Dec 30, 2024
It was noticed in #4568 that exceptions in cron jobs aren't logged. This is very important.
jonathanmetzman
added a commit
that referenced
this pull request
Dec 30, 2024
It was noticed in #4568 that exceptions in cron jobs aren't logged. This is very important.
jonathanmetzman
added a commit
that referenced
this pull request
Jan 2, 2025
It was noticed in #4568 that exceptions in cron jobs aren't logged. This is very important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocess count for fuzz task went to zero after #4564 got deployed, reverting.
#4528 is also being reverted because it introduced the following error into the fuzz task scheduler, which caused fuzz tasks to stop being scheduled: