Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 4564 and 4528 #4568

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Revert 4564 and 4528 #4568

merged 2 commits into from
Dec 28, 2024

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Dec 28, 2024

The preprocess count for fuzz task went to zero after #4564 got deployed, reverting.

#4528 is also being reverted because it introduced the following error into the fuzz task scheduler, which caused fuzz tasks to stop being scheduled:

Traceback (most recent call last):
  File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 68, in <module>
    sys.exit(main())
             ^^^^^^
  File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 64, in main
    return 0 if task_module.main() else 1
                ^^^^^^^^^^^^^^^^^^
  File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 304, in main
    return schedule_fuzz_tasks()
           ^^^^^^^^^^^^^^^^^^^^^
  File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 284, in schedule_fuzz_tasks
    available_cpus = get_available_cpus(project, regions)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 247, in get_available_cpus
    result = pool.starmap_async(  # pylint: disable=no-member
             ^^^^^^^^^^^^^^^^^^
AttributeError: 'ProcessPoolExecutor' object has no attribute 'starmap_async'

@vitorguidi vitorguidi changed the base branch from master to oss-fuzz December 28, 2024 14:33
@vitorguidi vitorguidi changed the title Revert 4564 Revert 4564 and 4528 Dec 28, 2024
@vitorguidi vitorguidi merged commit 126d1c5 into oss-fuzz Dec 28, 2024
3 checks passed
@vitorguidi vitorguidi deleted the chore/revert-4564 branch December 28, 2024 15:08
vitorguidi added a commit that referenced this pull request Dec 28, 2024
#4568 resolved the merge conflict on get_batch_regions incorrectly, this
PR fixes that.

Testing: ran schedule-fuzz locally to completion
@jonathanmetzman
Copy link
Collaborator

lgtm

Fascinating, I think we're not doing proper error reporitng in k8s https://pantheon.corp.google.com/errors;filter=%5B%5D?project=clusterfuzz-external&e=-13802955&mods=logs_tg_prod look

jonathanmetzman added a commit that referenced this pull request Dec 30, 2024
jonathanmetzman added a commit that referenced this pull request Dec 30, 2024
It was noticed in #4568 that exceptions in cron jobs aren't logged.
This is very important.
jonathanmetzman added a commit that referenced this pull request Dec 30, 2024
It was noticed in #4568 that exceptions in cron jobs aren't logged.
This is very important.
jonathanmetzman added a commit that referenced this pull request Jan 2, 2025
It was noticed in #4568 that exceptions in cron jobs aren't logged. This
is very important.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants