Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching paginated results with a filter. #4511

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix fetching paginated results with a filter. #4511

merged 2 commits into from
Dec 17, 2024

Conversation

jonathanmetzman
Copy link
Collaborator

Filters mean that pagination isn't handled for you.

@jonathanmetzman
Fix fetching paginated results with a filter.
cecd9da 
Filters mean that pagination isn't handled for you.
vitorguidi
vitorguidi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo making the upper bound assumption explicit

@jonathanmetzman jonathanmetzman merged commit 6c26da1 into master Dec 17, 2024
6 checks passed
@jonathanmetzman jonathanmetzman deleted the listbl branch December 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorguidi vitorguidi vitorguidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanmetzman @vitorguidi