Reduce bug filing threshold for libfuzzer-based Android crashes #4474
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
AashutoshMurthy
force-pushed
the
startup_update
branch
from
6ad51b3 to
a9863d2
Compare
|
/gcbrun |
This PR was created in response to the message chain on b/372321538. |
| def test_is_libfuzzer_android_startup_crash_1(self): | ||
| """If this unreproducible testcase (libfuzzer) is crashing frequently, | ||
| then it is an important crash.""" | ||
| self.mock.get_last_successful_hour.return_value = 417325 |
There was a problem hiding this comment.
What is the point of using this return value? I assume in production maybe it is stored as milliseconds and thus represented by an integer like this... if that is the case, please add a comment to clarify or modify the variable names to indicate such
There was a problem hiding this comment.
I used this value from an existing test as reference here.
| continue | ||
| # Check if the crash is a startup crash, i.e. it is causing the fuzzer | ||
| # to crash on startup and not allowing the fuzzer to run longer | ||
| if not _is_libfuzzer_android_startup_crash(testcase): |
There was a problem hiding this comment.
Can we rearrange this logic to check that this is on the android platform. Something like:
def _is_libfuzzer_android_startup_crash(testcase): # <--- Rename to something more indicative? (ex. is_blocking_progress)
"""Checks if the given testcase is an android libfuzzer crash"""
...
def is_crash_important_android(testcase):
if _is_libfuzzer_android_startup_crash:
# important
if not _is_crash_important(testcase):
if testcase.platform == android and not is_crash_important_android(testcase):
continue
There was a problem hiding this comment.
I have updated the logic as per your request. Please take a look.
AashutoshMurthy
force-pushed
the
startup_update
branch
from
a9863d2 to
591d6c5
Compare
|
/gcbrun |
Updated triage.py to file bugs for fuzzer crashes by lowering the threshold limit. These fuzzers run on Android platform and on libfuzzer engine.
AashutoshMurthy
force-pushed
the
startup_update
branch
from
b880489 to
abcf850
Compare
|
/gcbrun |
Updated triage.py to file bugs for fuzzer crashes by lowering the threshold limit. These fuzzers run on Android platform and on libfuzzer engine.