tasks: add support for both 'jobs-android' and device specific subqueues #4013
Conversation
paulsemel
force-pushed
the
add-android-generic-queue-support
branch
from
399e8f2 to
2581fe9
Compare
|
Mark do you understand how this is different from Haiku's queing system for Android? |
In chrome, we need to have generic jobs that can be scheduled on any devices. This PR will make sure generic tasks keep getting pulled even when subqueues are set-up.
paulsemel
force-pushed
the
add-android-generic-queue-support
branch
from
2581fe9 to
c076299
Compare
| def get_android_regular_task(): | ||
| """Get an android regular task.""" | ||
| if not environment.get_value('CF_ALLOWS_LISTENING_GENERIC_QUEUE') or \ | ||
| not environment.get_value('QUEUE_OVERRIDE'): |
There was a problem hiding this comment.
I don't believe we set the QUEUE_OVERRIDE var anywhere in our tests. Unless it's done via some environment init, should this be OS_OVERRIDE?
| task = get_regular_task(queue=regular_queue()) | ||
| if not task: | ||
| # We then try the generic queue. | ||
| task = get_regular_task(queue=generic_android_queue()) |
There was a problem hiding this comment.
I'm concerned that pulling from the generic queue will lead to incompatible testcases being picked up (like the error log shows below).
platform (android:coral_hwasan:master) does not match with ours (android:redfin_hwasan:master), exiting-
Is that right? If so, the testcase ("task") will be re-added to the top of the queue and continue in a cycle, meaning the bot will never move on to fuzzing tasks, which only occur when no testcases are left.
| @@ -190,6 +195,21 @@ def get_regular_task(queue=None): | |||
| return task | |||
|
|
|||
|
|
|||
| def get_android_regular_task(): | |||
| """Get an android regular task.""" | |||
| if not environment.get_value('CF_ALLOWS_LISTENING_GENERIC_QUEUE') or \ | |||
There was a problem hiding this comment.
As discussed in meet, let's make this default as opposed to introducing new env var
add support for both 'jobs-android' and device specific subqueues This is a port of google#4013 for Android platform
add support for both 'jobs-android' and device specific subqueues This is a port of #4013 for Android platform
jonathanmetzman
force-pushed
the
master
branch
from
a714059 to
f4df493
Compare
In chrome, we need to have generic jobs that can be scheduled on any devices. This PR will make sure generic tasks keep getting pulled even when subqueues are set-up. This PR is preliminary work for us to add subqueues on our android devices.