Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e subtask duration metric collection #3698

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Conversation

letitz
Copy link
Collaborator

@letitz letitz commented Jan 29, 2024

  • Adds unit tests, which reproduced the bugs
  • Fixes an inversion in the computation of the task duration, which was always negative
  • Records the e2e duration from preprocess start time to subtask end time instead of only the current subtask's duration, as was the intent

@letitz letitz changed the title Fix metric collection Fix e2e subtask durationmetric collection Jan 29, 2024
@letitz letitz changed the title Fix e2e subtask durationmetric collection Fix e2e subtask duration metric collection Jan 29, 2024
@letitz letitz marked this pull request as ready for review January 29, 2024 22:53
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 8a8c7d8 into google:master Jan 30, 2024
7 checks passed
@letitz letitz deleted the metric branch January 30, 2024 19:18
jonathanmetzman pushed a commit that referenced this pull request Apr 4, 2024
Using a context manager class to wrap task execution. Improves on #3698.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants