-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e subtask duration metric collection #3698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
letitz
commented
Jan 29, 2024
•
edited
Loading
edited
- Adds unit tests, which reproduced the bugs
- Fixes an inversion in the computation of the task duration, which was always negative
- Records the e2e duration from preprocess start time to subtask end time instead of only the current subtask's duration, as was the intent
letitz
changed the title
Fix metric collection
Fix e2e subtask durationmetric collection
Jan 29, 2024
letitz
changed the title
Fix e2e subtask durationmetric collection
Fix e2e subtask duration metric collection
Jan 29, 2024
jonathanmetzman
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonathanmetzman
pushed a commit
that referenced
this pull request
Apr 4, 2024
Using a context manager class to wrap task execution. Improves on #3698.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.