Make check_for_bad_build uworker safe #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return is_bad_build, crash_result.should_ignore(), build_run_console_output | ||
|
|
||
|
|
||
| def update_build_metadata(job_type, crash_revision, is_bad_build, |
There was a problem hiding this comment.
So is this going to be done on the tworker in postprocess?
There was a problem hiding this comment.
Yes, update_build_metadata queries the database thru the call to data_handler.get_build_state and then conditionally writes back with data_handler.add_build_metadata.
The next step would be to transmit the build data to the tworker postprocess and then call update_build_metadata from there.
jonathanmetzman
added a commit
that referenced
this pull request
Oct 11, 2023
This reverts commit 3e2e223.
jonathanmetzman
pushed a commit
that referenced
this pull request
Oct 26, 2023
Reland of #3416 So basically, what I changed is that we're now returning `False, True, None` when `'BAD_BUILD_CHECK'` is not set. This leads `update_build_metadata` to return early. --------- Co-authored-by: jonathanmetzman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonathanmetzman could you please take a look?