Add support for centipede options file #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
paulsemel
force-pushed
the
add-support-for-centipede-options
branch
from
40a6266 to
c87a3d1
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
paulsemel
force-pushed
the
add-support-for-centipede-options
branch
3 times, most recently
from
0cfc181 to
3629711
Compare
letitz
reviewed
Oct 6, 2023
letitz
reviewed
Oct 6, 2023
Comment on lines
+114
to
+113
| if key not in arguments: | ||
| arguments[key] = val |
There was a problem hiding this comment.
Consider arguments.setdefault(key, val).
There was a problem hiding this comment.
arguments is not an actual dictionary, it's a custom object that vaguely behaves like one. I first wanted to clean the implementation of it, but that's not the purpose of this CL, so I prefer leaving things like it.
paulsemel
force-pushed
the
add-support-for-centipede-options
branch
2 times, most recently
from
f4abbbe to
71c0360
Compare
Comment on lines
+66
to
+69
| '-exit_on_crash=1', | ||
| f'-fork_server={_SERVER_COUNT}', | ||
| f'-rss_limit_mb={_RSS_LIMIT}', | ||
| f'-address_space_limit_mb={_ADDRESS_SPACE_LIMIT}', |
There was a problem hiding this comment.
Does centipede support arguments of the sort -blah instead of --blah?
There was a problem hiding this comment.
Yep, it supports single and double dash.
paulsemel
force-pushed
the
add-support-for-centipede-options
branch
from
fa85aaf to
5c4469a
Compare
|
I'll merge this Monday. |
DonggeLiu
approved these changes
Oct 8, 2023
|
ping @jonathanmetzman, can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for an
.optionsfile for centipede. This allows fuzzing targets to overwrite their own options.