Skip to content

Commit

Permalink
build_manager: allow remote unpacking when unpacking everything (#4473)
Browse files Browse the repository at this point in the history
Now that we are lazily checking for fuzzing targets, it makes sense to
allow remote unpacking even when unpacking the full archive.
Furthermore, it seems that remote unpacking performances are much higher
than local unpacking on CF bots, so this might improve overall
performances of the build_manager.
  • Loading branch information
paulsemel authored Dec 9, 2024
1 parent 089d9ef commit 06173d2
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/clusterfuzz/_internal/build_management/build_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,11 @@ def _open_build_archive(self, base_build_dir: str, build_dir: str,
# if the HTTP URL is compatible with remote unzipping.
allow_unpack_over_http = environment.get_value(
'ALLOW_UNPACK_OVER_HTTP', default_value=False)
can_unzip_over_http = (
allow_unpack_over_http and not self._unpack_everything and
http_build_url and
can_unpack_over_http = (
allow_unpack_over_http and http_build_url and
build_archive.unzip_over_http_compatible(http_build_url))

if not can_unzip_over_http:
if not can_unpack_over_http:
return self._download_and_open_build_archive(base_build_dir, build_dir,
build_url)
# We do not emmit a metric for build download time, if using http
Expand Down

0 comments on commit 06173d2

Please sign in to comment.