This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Fix closurebuilder.py for Python 3 #1092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently closurebuilder.py throws this when run in Python 3:
```
Traceback (most recent call last):
File "third-party-downloads/build/closurebuilder.py", line 300, in <module>
main()
File "third-party-downloads/build/closurebuilder.py", line 260, in main
out.writelines([js_source.GetPath() + '\n' for js_source in deps])
TypeError: a bytes-like object is required, not 'str'
```
Writing to `sys.stdout` rather than `sys.stdout.buffer` fixes this.
Reported at google/blockly-games#195 (comment)
|
Thanks Neil. I'm surprised that the existing code doesn't work. Merging this shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently closurebuilder.py throws this when run in Python 3:
Writing to
sys.stdoutrather thansys.stdout.bufferfixes this.Reported at google/blockly-games#195 (comment)
Related to #849, but that issue failed to actually modify closurebuilder.py