-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make unitree go2 mjx model compatible with hfields #77
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these changes look good. Although you can use impratio for pyramidal friction, it's more stable for elliptic cone friction.
The reason you are seeing more slippage and had to raise the friction is probably due to removing impratio, but that's OK. I'll leave it to you and @kevinzakka to discuss whether to update friction, as he knows better than me where those values came from.
@erikfrey I'm okay with increasing friction, but since elliptic is now supported by MJX, should we not switch to impratio + elliptic? |
As a rule of thumb, for locomotion you can rely on pyramidal friction - it's cheaper to simulate but still transfers to real just fine. |
Gotcha, then all good for increasing friction! |
@erikfrey Can we get this merged in? |
@7oponaut Can you sign the CLA? |
@kevinzakka yes, once CLA is signed. |
Sorry for taking your time, I was under the impression that I am contributing to an open source repository. I am not comfortable with signing the CLA. I'm taking issue with 3) in the CLA: I'm not a lawyer or a Google employee and I don't want to deal with litigatory issues in case Google later commercializes any of this repository and gets sued for whatever reason. |
I had two issues when attempting to use
unitree_go2/go2_mjx.xml
in scenes with hfields such asgoogle_barkour_vb/scene_hfield_mjx.xml
:margin
attribute in thego2
class default section results in the following error:This PR removes these two attributes, resulting in no
margin
and animpratio="1"
default.I don't have a full understanding of how these changes affect the simulation. Please determine if they should be merged.
@saran-t requested this PR after encountering my post about the instability on X.
p.s. My version of the file has additional changes which might be helpful