Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMI-Gripper #106

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

UMI-Gripper #106

wants to merge 13 commits into from

Conversation

omarrayyann
Copy link

This PR adds the UMI Gripper model. Feel free to suggest any suggestions to improve the quality of the model. The SolidWorks files were first exported to URDFs by @abanesjo.

Model Screenshot:

umi_gripper

Model Video with Objects:

Screen.Recording.2024-10-29.at.10.11.14.PM.mov

Possible Improvements:

  • Adding support for two mirrors. Otherwise, the one currently added mirror will need to be removed.

Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@omarrayyann omarrayyann mentioned this pull request Oct 29, 2024
@kevinzakka kevinzakka self-requested a review October 30, 2024 20:12
Copy link
Collaborator

@kevinzakka kevinzakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initial PR, left some comments!

umi_gripper/assets/.DS_Store Outdated Show resolved Hide resolved
umi_gripper/assets/base_link.STL Outdated Show resolved Hide resolved
umi_gripper/main.py Outdated Show resolved Hide resolved
umi_gripper/scene.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
umi_gripper/umi_gripper.xml Outdated Show resolved Hide resolved
omarrayyann and others added 3 commits October 31, 2024 03:14
- Addressed comments from google-deepmind#106
- Made the style more consistent with other models in the repo.
@omarrayyann
Copy link
Author

I added the license from the original design here.

@kevinzakka
Copy link
Collaborator

Hi @omarrayyann, things got delayed due to CoRL. We'll get to this next week at the latest, thanks again for your contribution!

Copy link
Member

@saran-t saran-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .DS_Store and the test/pycache changes from the PR.

@omarrayyann
Copy link
Author

@saran-t Removed

@omarrayyann omarrayyann requested a review from saran-t December 3, 2024 18:52
@omarrayyann
Copy link
Author

@saran-t following up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants