Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bf16 weight and dynamic shape #242

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Support bf16 weight and dynamic shape #242

merged 2 commits into from
Nov 12, 2024

Conversation

yuanzhedong
Copy link
Contributor

  • Fix crash when weight is not support by numpy(e.g. BFloat16)
  • Fix crash when the shape is dynamic(not an integer)

@yuanzhedong
Copy link
Contributor Author

yuanzhedong commented Nov 12, 2024 •
edited
Loading

Tested with bf16 weight and dynamic shape
image

@yuanzhedong
Copy link
Contributor Author

Hi @jinjingforever, could you take a look when have time? Thank you!

@jinjingforever
Copy link
Collaborator

Thanks @yuanzhedong! I will let @yijie-yang take a look.

yijie-yang
yijie-yang approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@yijie-yang yijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm!

@yuanzhedong yuanzhedong force-pushed the yz/fix-bf16-dynamic-shape branch from 83cd11a to f55736b Compare November 12, 2024 22:15
@yuanzhedong
Copy link
Contributor Author

Thank you, lgtm!

Thank you! Just fixed the format using

pyink --pyink-use-majority-quotes --pyink-indentation=2 --preview --unstable --line-length 80 --extend-exclude .downloads --extend-exclude "\.pyi" ./

@yijie-yang yijie-yang merged commit ffa84f7 into google-ai-edge:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yijie-yang yijie-yang yijie-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanzhedong @jinjingforever @yijie-yang