Playwright CI #206
Merged
Playwright CI #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Turn up local server | ||
| run: | | ||
| cd src/server | ||
| scripts/setup_local_dev.sh |
There was a problem hiding this comment.
One thing I probably forgot to mention: we also want to use the latest UI code to start the server with. To do that,
- cd into
src/ui - run:
npm install -g @angular/cliandnpm install - run
./scripts/build_and_update_python_package.sh. This will build the angular app and copy the files to the proper server directory.
Then you can run model-explorer... to start the server with the latest UI.
There was a problem hiding this comment.
Yes definitely! Can we set up the UI test in a separate PR since it also involves some npm installation and js related debugging?
| paths: | ||
| - 'src/server/**' | ||
| - '.github/workflow/**' | ||
| - 'ci/**' |
There was a problem hiding this comment.
Also add the path to ui code since we are using the latest ui code to start the server with (see comment above)
| pull_request: | ||
| # Triggered by default activities (synchronize, opened, reopened) + labeled. | ||
| # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request | ||
| types: [labeled, synchronize, opened, reopened] | ||
| branches: ["main"] | ||
| paths: | ||
| - 'src/server/**' |
There was a problem hiding this comment.
Add the path to ui code here too
jinjingforever
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.