[경재] 숫자야구 구현 #1
Open
[경재] 숫자야구 구현 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyeongjae-ham
commented
Dec 10, 2024
gyeongjae-ham
commented
- 요구사항 정리
- 숫자 야구 숫자 객체 생성 및 검증
- 숫자 야구 게임 객체 생성 및 검증
- 입,출력 구현
- 게임 실행부 작성
요구사항 정리
숫자야구 숫자를 검증하는 BaseballGameNumber를 생성하고 검증한다
안쓰는 객체를 이용하는 테스트 제거
숫자 야구 숫자를 생성하는 객체 생성 및 검증
게임을 초기화하고 진행하는 객체 생성 및 검증
입력 객체 생성
출력 객체 생성
게임 진행하는 main class 추가
hongxeob
requested changes
Dec 15, 2024
java-playground/src/main/java/org/gonza/javaplayground/OutputView.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/OutputView.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/OutputView.java
Outdated
Show resolved
Hide resolved
java-playground/src/test/java/org/gonza/javaplayground/FixNumberGenerator.java
Outdated
Show resolved
Hide resolved
java-playground/src/test/java/org/gonza/javaplayground/BaseballGameTest.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/InputView.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Outdated
Show resolved
Hide resolved
반복되는 생성문 method화 시키기
입력과 출력 구분해서 작성
생성자 부분 fixture로 대체
method 명 좀 더 명확하게 수정
아웃 조건 추가
Heonbyeong
reviewed
Dec 18, 2024
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Outdated
Show resolved
Hide resolved
currenjin
reviewed
Dec 18, 2024
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/RandomNumberGenerator.java
Outdated
Show resolved
Hide resolved
java-playground/src/main/java/org/gonza/javaplayground/JavaPlaygroundApplication.java
Show resolved
Hide resolved
Heonbyeong
reviewed
Dec 18, 2024
java-playground/src/main/java/org/gonza/javaplayground/JavaPlaygroundApplication.java
Outdated
Show resolved
Hide resolved
Heonbyeong
reviewed
Dec 18, 2024
java-playground/src/main/java/org/gonza/javaplayground/JavaPlaygroundApplication.java
Show resolved
Hide resolved
Heonbyeong
reviewed
Dec 18, 2024
Heonbyeong
reviewed
Dec 18, 2024
java-playground/src/main/java/org/gonza/javaplayground/RandomNumberGenerator.java
Outdated
Show resolved
Hide resolved
병헌님 & 현진님 리뷰 반영
leeMK09
reviewed
Dec 19, 2024
java-playground/src/main/java/org/gonza/javaplayground/BaseballGameNumber.java
Show resolved
Hide resolved
사용 객체에서 자릿수를 전달하도록 수정
testcode에 반영
사용 객체에서 자릿수 넣어주기
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.