Add "Use strong CRC for texture dump" option. #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this option is on, textures dumped with alternative strong CRC. Dumps with strong CRC are stored in "strong_crc" subfolder of dump folder. Hires texture load is changed: if HD texture with RiceCRC is not found, the plugin tries to load HD texture with alternative strong CRC.
|
I am stumbling into crashing issues with these changes. Most easily reproducible is running GoldenEye with HD textures on and firing a gun. This does not happen with latest master it seems. |
I'll check it, thanks! |
…_strong_hd_texture_hash
Fixed. |
cheinr
pushed a commit
to cheinr/GLideN64
that referenced
this pull request
Sep 8, 2024
* [GLideNHQ] Add checksum64strong(...) function for strong checksum calculation. * Add "Use strong CRC for texture dump" option. When this option is on, textures dumped with alternative strong CRC. Dumps with strong CRC are stored in "strong_crc" subfolder of dump folder. Hires texture load is changed: if HD texture with RiceCRC is not found, the plugin tries to load HD texture with alternative strong CRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: RiceCRC fails to calculate different CRC for some textures, see #2806
Solution:
add new dump mode: "Use strong CRC for texture dump".
If some textures fail to dump with RiceCRC, texture artist should use alternative dump mode.
Texture format remains the same, only checksum in texture name is different.
During textures load, graphics plugin will first try to load HD texture as usual, with RiceCRC.
If load fails, the plugin calculates alternative CRC and tries to load HD texture with it.