Don't sanitize controls attribute #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dometto
added a commit
to repotag/gollum-lib
that referenced
this pull request
Nov 27, 2022
aljungberg
added a commit
to aljungberg/gollum-lib
that referenced
this pull request
Feb 9, 2023
…le). - Using the `="true"` work-around as in gollum#430. - The change in `sanitization.rb` further addresses gollum/gollum#1587 by allowing more of the standard video properties. - Also featured: less escaping, capitalisation fix.
dometto
pushed a commit
that referenced
this pull request
Mar 21, 2023
* New: `<<Video ..., auto=true>>` plays clips inline on a loop (GIF style). - Using the `="true"` work-around as in #430. - The change in `sanitization.rb` further addresses gollum/gollum#1587 by allowing more of the standard video properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gollum/gollum#1856
Our Video and Audio Macros are rendering
controlsattributes in the<video>and<audio>tags. Two problems:controlswas not added to Loofah's safelist. This was not a problem until we started sanitizing Macro output (in sanitize macros #402).controlsattribute is still being sanitized due to HTML5 empty attributes are being scrubbed flavorjones/loofah#242This PR fixes 1 by adding
controlsto the safelist, and 2 by using a workaround:controls="true"as opposed to justcontrolsis not sanitized by loofah. The latter should not be necessary, and when the loofah issue is resolved we can revert that change.