Use Pathname throughout gollum-lib for consistent pathname handling

[bartkamphorst]

My proposal is that all path and dir variables will be Pathname objects, and that name will remain a String.

[dometto]

I assume this will also solve the Windows problems caused by hardcoded slashes?

[bartkamphorst]

Hopefully, although we might run into other issues as well.

[bartkamphorst]

@dometto For the test suite, would you prefer
assert_equal 'Mordor/Eye-Of-Sauron.md', map[3].path.to_s or
assert_equal Pathname.new('Mordor/Eye-Of-Sauron.md'), map[3].path?

[bartkamphorst]

ping @dometto .

[dometto]

Sorry, missed this! I think I would prefer
assert_equal Pathname.new('Mordor/Eye-Of-Sauron.md'), map[3].path
Because map[3].path.to_s doesn't make explicit that map[3].path is a Pathname (since ordinary strings also respond to #to_s).

[bartkamphorst]

👍

[dometto]

#437 makes sure Pathname is used throughout page.rb and file.rb. There may be some other cases where switching to Pathname is preferred.