Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically detect directory in page name #11

Closed
jamieoliver opened this issue Apr 11, 2013 · 5 comments
Closed

Automatically detect directory in page name #11

jamieoliver opened this issue Apr 11, 2013 · 5 comments
Assignees
@jamieoliver
Labels
enhancement
Milestone
5.0

Comments

@jamieoliver
Copy link

As per discussion in #10. The separate directory parameter in various methods should be removed and automatically detected in the page name. This will need to be done sympathetically so as to minimise the impact on existing code.
@raphendyr
Copy link

👍

@jamieoliver jamieoliver mentioned this issue May 29, 2013
Merged
@jamieoliver jamieoliver self-assigned this Jun 24, 2014
@gerwitz
Copy link

gerwitz commented Oct 10, 2014

+1

@deric deric mentioned this issue Jan 11, 2015
Closed
@gerwitz
Copy link

gerwitz commented Jun 8, 2016

Thankfully, there's nothing to prevent an app built with gollum-lib from ignoring the directory parameter. So we faked this behavior in rails-wiki.

@bartkamphorst bartkamphorst added this to the 5.0 milestone Aug 14, 2016
@dometto
Copy link
Member

dometto commented Apr 30, 2017

#216 will help with this.

@dometto
Copy link
Member

dometto commented Apr 28, 2019

This has been implemented in #322 and #326 -- will be released in 5.x

@dometto dometto closed this as completed Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamieoliver jamieoliver

Labels
enhancement
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
5 participants
@gerwitz @dometto @jamieoliver @bartkamphorst @raphendyr