Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 / aarch64 installer support #24

Closed
wants to merge 1 commit into from
Closed

Conversation

cryptobench
Copy link
Member

Currently the installer won't install ARM binaries and just plain out exit, but this change adds support for downloading ARM binaries.

Copy link
Contributor

@mfranciszkiewicz mfranciszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, detect_dist passes without an error, but the CPU type is not used when installing packages.

  1. The installer downloads the x86_64 version despite of the CPU architecture. I.e., the following should be installed:
    https://github.com/golemfactory/yagna/releases/download/v0.9.0/golem-requestor-linux_aarch64-v0.9.0.tar.gz
    instead of
    https://github.com/golemfactory/yagna/releases/download/v0.9.0/golem-requestor-linux-v0.9.0.tar.gz

  2. For the provider variant, this script installs ya-runtime-wasi and ya-runtime-vm, which have no aarch64 build pipelines / releases

@cryptobench
Copy link
Member Author

There's actually an issue that I didn't think about when testing this. There are no ARM builds available for Mac OS, so i'm not even able to test it using the installer.

@nieznanysprawiciel
Copy link
Contributor

Blocked by: golemfactory/yagna#1776

@krunch3r76
Copy link

krunch3r76 commented Jul 17, 2023

what a coincidence me too at first! please see my pull #44 that handles the url resolution to the correct release tarbells. i don't have an arm at the moment to test on coincidentally as well. but i made some strong inferences. anyway, my issue #45 and pull #44 is specific to linux arm. it is my understanding from this thread that we are not yet interested in supporting cputype arm64 (which is the reported type on Darwin for mac's with arm cpu's) because neither requestor nor provider will run on it right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants