Rename WorkContext to ExeUnit #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved unit tests to related directories in src BREAKING CHANGE: The API object WorkContext (ctx) has been renamed to ExeUnit. All references to WorkContext must be updated.
…rdown` method BREAKING CHANGE: The current use of the `WorkContext.before()` method should be replaced with`ExeUnit.setup()`
mgordel
changed the title
SewerynKras
reviewed
Jun 19, 2024
Comment on lines
45
to
58
| await Promise.allSettled([ | ||
| pool.withLease(async (lease) => | ||
| lease | ||
| .getExeUnit() | ||
| .then((exe) => exe.run(`echo Hello, Golem from the first machine! 👋 ${exe.provider.name}`)) | ||
| .then((res) => console.log(res.stdout)), | ||
| ), | ||
| pool.withLease(async (lease) => | ||
| lease | ||
| .getExeUnit() | ||
| .then((exe) => exe.run(`echo Hello, Golem from the second machine! 👋 ${exe.provider.name}`)) | ||
| .then((res) => console.log(res.stdout)), | ||
| ), | ||
| ]); |
There was a problem hiding this comment.
I think a better example would be to show that if you re-use a lease the setup and teardown are only executed once (for example make w pool with concurrency 2 and run 10 tasks on it)
There was a problem hiding this comment.
or we could borrow the example from TE where we upload a file, add lines to it in every task function and then display the contents at the end
There was a problem hiding this comment.
or maybe... an example with rendering... 🫣 intentionally change the name to rendering.ts, this is the original example where it is necessary to use the setup .. (?)
I added it for comparison - rendering.ts
Example for setup and teardown
SewerynKras
approved these changes
Jun 20, 2024
… into mgordel/JST-984/exe-unit-rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkContexttoExeUnitOneOfandManyOfOptionsincludingsetupandteardownfunctionBREAKING CHANGE: The API object WorkContext (ctx) has been renamed to ExeUnit. All references to WorkContext must be updated.
BREAKING CHANGE: The current use of the
WorkContext.before()methodshould be replaced with
ExeUnit.setup()