JST-652: Implement coding conventions #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgordel
approved these changes
Dec 15, 2023
SewerynKras
reviewed
Dec 15, 2023
src/golem_network/golem_network.ts
Outdated
| await this.yagna.connect(); | ||
| this.api = this.yagna.getApi(); | ||
|
|
||
| this.initializedState = true; |
There was a problem hiding this comment.
Not sure we need all three api, yagna and initializedState, can't we achieve the same business logic with just api?
public async init() {
if (this.isInitialized()) {
return;
}
const yagna = new Yagna(this.config.yagna);
// this will throw an error if yagna is not running
await yagna.connect();
this.api = this.yagna.getApi();
}
public isInitialized() {
return this.api !== null
}
src/golem_network/golem_network.ts
Outdated
| import { RunJobOptions } from "../job/job"; | ||
| import { GolemError } from "../error/golem-error"; | ||
|
|
||
| type GolemNetworkConfig = Partial<RunJobOptions> & { yagna?: YagnaOptions }; |
There was a problem hiding this comment.
good idea with the type, can we export it in the root index.ts?
SewerynKras
approved these changes
Dec 15, 2023
grisha87
force-pushed
the
task/JST-652/implement-coding-conventions
branch
from
562ab6a to
7b47d58
Compare
BREAKING CHANGE: `ActivityPoolService.isRunning` is now a function, and not a getter. `Job.isRunning` is now a function, and not a getter.
grisha87
force-pushed
the
task/JST-652/implement-coding-conventions
branch
from
7b47d58 to
50cb9d8
Compare
|
🎉 This PR is included in version 2.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the agreed coding conventions:
_setX, getXaccessorscamelCasewithUPPER_CASEandPascalCasein other cases