fix: remove axios as runtime dependency #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
force-pushed
the
feature/JST-613
branch
from
1825fa4 to
876203a
Compare
grisha87
approved these changes
Dec 15, 2023
README.md
Outdated
| @@ -241,3 +241,5 @@ yarn format | |||
| - Learn about preparing your own Docker-like images for | |||
| the [VM runtime](https://docs.golem.network/docs/creators/javascript/examples/tools/converting-docker-image-to-golem-format) | |||
| - Write your own app with [JavaScript API](https://docs.golem.network/docs/creators/javascript/quickstarts/quickstart) | |||
|
|
|||
| ## How to | |||
There was a problem hiding this comment.
Looks like added by mistake. I'm going to remove this.
| @@ -178,7 +178,7 @@ export class PaymentService { | |||
| } | |||
|
|
|||
| private async getPaymentAddress(): Promise<string> { | |||
| const { data } = await this.yagnaApi.identity.getIdentity(); | |||
| const data = await this.yagnaApi.identity.getIdentity(); | |||
There was a problem hiding this comment.
Check with regression tests
|
🎉 This PR is included in version 2.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JST-613