JST-429: Gftp bugfix and refactor #612
Conversation
JST-429: Fixed gftp bug with incorrect initialization when there are no tasks in the executor. Additionally, gftp has been refactored, getting rid of the old @rauschma/stringio dependency which has been replaced with native nodejs modules.
mgordel
requested review from
grisha87,
pgrzy-golem,
cryptobench and
SewerynKras
There was a problem hiding this comment.
One thing I'm concerned about is the use of ? in declaration and later usage.
What this does is that it will silently ignore a lot of issues at runtime.
We should have a discussion about our coding style, and consider either using null values/default objects, or ! instead or choosing a completely different approach.
|
@pgrzy-golem I agree that it's not a very nice style, but in a situation where we initialize the object later after its creation, this will be a problem and will require refactoring of objects, so we can discuss it and agree on a common approach, but maybe as part of another task |
|
🎉 This PR is included in version 0.12.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JST-429: Fixed gftp bug with incorrect initialization when there are no tasks in the executor.
Additionally, gftp has been refactored, getting rid of the old
@rauschma/stringiodependency which has been replaced with native nodejs modules.