Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scratch Goth from tests #606

Merged
merged 79 commits into from
Oct 6, 2023
Merged

Scratch Goth from tests #606

merged 79 commits into from
Oct 6, 2023

Conversation

cryptobench
Copy link
Member

No description provided.

@cryptobench cryptobench changed the base branch from master to beta October 2, 2023 09:08
@cryptobench cryptobench marked this pull request as draft October 2, 2023 09:39
@cryptobench
Copy link
Member Author

Made all changes and tested the release pipeline to confirm all things are working.

@cryptobench cryptobench requested a review from mgordel October 5, 2023 13:55
Copy link
Contributor

@mgordel mgordel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small comments, but overall ok

tests/docker/start_provider.sh Outdated Show resolved Hide resolved
.github/workflows/examples-nightly.yml Show resolved Hide resolved
.github/workflows/goth-nightly.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/e2e/_setup.ts Outdated Show resolved Hide resolved
@cryptobench
Copy link
Member Author

@mgordel All things should be addressed and I just tested the full release pipeline which gave green light after the changes.

@@ -1,7 +1,7 @@
name: Regular CI Pipeline

on:
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain "pull_request" for ci.yml because we want it to be run only on code which is "pull request to master" for example.

@cryptobench cryptobench merged commit fc9f785 into beta Oct 6, 2023
11 checks passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 0.11.3-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants