-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scratch Goth from tests #606
Conversation
Made all changes and tested the release pipeline to confirm all things are working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few small comments, but overall ok
examples/docs-examples/examples/selecting-providers/whitelist.mjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcin Gordel <[email protected]>
…golem-js into chore/scratch-goth
@mgordel All things should be addressed and I just tested the full release pipeline which gave green light after the changes. |
.github/workflows/ci.yml
Outdated
@@ -1,7 +1,7 @@ | |||
name: Regular CI Pipeline | |||
|
|||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should remain "pull_request" for ci.yml
because we want it to be run only on code which is "pull request to master" for example.
🎉 This PR is included in version 0.11.3-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 0.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.