Chore/dependency pruning and maintenance #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the library was installing the pino-pretty-logger, axios and bottleneck when not using it at all some of the dependencies were reallyd dependencies for the examples and got moved there
SewerynKras
requested changes
Oct 14, 2024
src/payment/payment.module.ts
Outdated
| @@ -97,7 +97,7 @@ export class PaymentModuleImpl implements PaymentModule { | |||
| constructor(deps: GolemServices, options?: PaymentModuleOptions) { | |||
| const network = options?.network ?? this.options.network; | |||
| const driver = options?.driver ?? this.options.driver; | |||
| const token = options?.token ?? MAINNETS.includes(network) ? "glm" : "tglm"; | |||
| const token = (options?.token ?? MAINNETS.includes(network)) ? "glm" : "tglm"; | |||
There was a problem hiding this comment.
I think you accidentally discovered a bug here! The logic is supposed to be
{
if (options?.token) return options.token
return MAINNETS.includes(network) ? "glm" : "tglm"
}but it's broken (actually, always has been!). Look at this code:
const token: string | undefined = "my-token"
const some_condition = true;
console.log(token ?? some_condition ? "glm" : "tglm"); // "glm"
console.log((token ?? some_condition) ? "glm" : "tglm"); // "glm"
SewerynKras
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.