docs(deposit): added example demonstrating the use of allocation with deposit #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Everything looks good. I just came to the conclusion that there's a lot that the users have to do in order to really use the feature - for the purpose of the example you had to create few functions wrapping the complexity of the process. These are candidates to be placed in the SDK itself which we should explore as a potential feature set for the SDK.
package.json
Outdated
| @@ -133,7 +133,8 @@ | |||
| "typedoc-plugin-markdown": "^3.17.1", | |||
| "typedoc-plugin-merge-modules": "^5.1.0", | |||
| "typedoc-theme-hierarchy": "4.1.2", | |||
| "typescript": "^5.3.3" | |||
| "typescript": "^5.3.3", | |||
| "viem": "^2.21.1" | |||
There was a problem hiding this comment.
I think this should be added only to the examples?
|
definitely worth considering. I see it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.