Fix TcpProxy for non HTTP communication #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgordel
requested changes
Aug 1, 2024
…no assumed timeout in waitFor RemoteProcess.isFinished is now completing correctly when the user breaks runAndStream using an abort controller . In addition, waitFor is no longer assuming a timeout of 30s for the user.
mgordel
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The current implementation of the TCP proxy failed to correctly transfer data back and forth for non HTTP communication. Trying to execute plain TCP use cases with this rendered it unusable and errornous.
Solution
This PR solves this by reimplementing the TCP Proxy logic and providing missing features such as buffering of the communication while waiting for the other endpoints to be fully ready to accept communication.
In addition:
waitForConditioninternal helper function towaitForand exposed this as a utility fromgolem-jsas this is a feature that gets implemented by many requestor scripts on their own.