fix: fixed the issue blocking GolemNetwork.disconnecte because of missing gftp #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
In cases when the requestor does not have
gftp
installed (you can move the file to a different location to test this),glm.disconnect()
was executed quickly and the script was not closing at all. Usingwtfnode
showed that afterglm.connect()
fails due to the missinggftp
, some connections to yagna were open:The solution
This PR removes the redundant
isConnected
check during thedisconnect
method execution, allowing the code to actually close the yagna connections. This way the V8 event loop can drain from work and the program can exit normally.This does not affect negatively the indempotency of the disconnect method at all: