-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user-defined challenge Accept payload #305
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 1716442) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/628635. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628635. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/628635. |
This PR (HEAD: 8ac9e2b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/628635. Important tips:
|
Message from Jeremy Hahn: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/628635. |
This PR (HEAD: 615e3b7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/628635. Important tips:
|
After a discussion on the ACME mailing list regarding RFC 8555, Section 7.5.1 "Responding to Challenges", I gained clarity that an empty response is not a strict requirement, and was pointed to acme-onion as an example.
I'm supporting device attestations, including acme-device-attest and a couple of custom challenge types which need the ability to submit a payload instead of an empty object.
This PR allows clients using this library to support such use cases.