Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: New methods: CreateBucket, DeleteBucket, SetWithChecksum. #978

Merged
merged 10 commits into from
Sep 7, 2023
Merged

s3: New methods: CreateBucket, DeleteBucket, SetWithChecksum. #978

merged 10 commits into from
Sep 7, 2023

Conversation

iredmail
Copy link
Contributor

@iredmail iredmail commented Sep 5, 2023 •
edited
Loading

@ReneWerner87
Copy link
Member

@iredmail thx
can you add an example in the readme

@iredmail
Copy link
Contributor Author

iredmail commented Sep 5, 2023

can you add an example in the readme

Sure, working on it. But seems GitHub Actions has some problem right now, could you please take a look?

ReneWerner87 and others added 3 commits September 5, 2023 10:21
@ReneWerner87
Merge branch 'main' into main
db6c457
@iredmail
Add example in README.
1ddcc7b 
Use `map[string][]byte` instead of `map[string]string`.
@iredmail
Fix incorrect sum.
e09d833
@ReneWerner87
Copy link
Member

@iredmail pls check
image

@iredmail iredmail changed the title s3: New method: SetWithChecksum. s3: New methods: CreateBucket, DeleteBucket, SetWithChecksum. Sep 6, 2023
@iredmail
Fix incorrect checksum (base64 encoded).
4dfe51a 
Create bucket in unittest instead of GitHub Actions.
@ReneWerner87 ReneWerner87 requested a review from gaby September 6, 2023 07:03
@ReneWerner87
Copy link
Member

@iredmail pls add some description for the new methods and some example to the readme

gaby
gaby approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing missing is the updated docs as suggested above

@iredmail
Copy link
Contributor Author

iredmail commented Sep 7, 2023

hi @ReneWerner87 @gaby

Is it ok now?

@gaby
Copy link
Member

gaby commented Sep 7, 2023

@iredmail Looks good

@ReneWerner87 ReneWerner87 merged commit 629c252 into gofiber:main Sep 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@gaby gaby gaby approved these changes

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 [Feature]: s3: support setting with checksum
3 participants
@iredmail @ReneWerner87 @gaby