Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeleteMany() to S3 Storage #1335

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Add DeleteMany() to S3 Storage #1335

merged 4 commits into from
Apr 12, 2024

Conversation

xEricL
Copy link
Contributor

@xEricL xEricL commented Apr 6, 2024

The aws s3 driver has a nice DeleteObjects() method for bulk-deleting multiple objects in a bucket. I added a basic DeleteMany(keys ...string) method that allows users to provide multiple keys to delete a set of objects in a single request.

@xEricL xEricL requested a review from a team as a code owner April 6, 2024 19:40
@xEricL xEricL requested review from gaby, sixcolors, ReneWerner87 and efectn and removed request for a team April 6, 2024 19:40
Copy link
Contributor

coderabbitai bot commented Apr 6, 2024

Walkthrough

The recent update introduces a DeleteMany method to the Storage struct within the s3 package, enabling the deletion of multiple keys at once. To ensure its reliability, a new test function has been crafted to verify the deletion process across several keys. This enhancement streamlines operations, improving efficiency in managing storage resources.

Changes

Files Summary
s3/README.md Documentation updated to include DeleteMany method.
s3/s3_methods.go Added DeleteMany(keys ...string) method to Storage struct.
s3/s3_methods_test.go Added Test_S3_DeleteMany to test deletion of multiple keys.

🐰✨
In the land of code and byte,
A rabbit hopped with all its might.
"Let's delete not one but many," it said,
With a hop and a skip, redundant data fled.
"For efficiency, we strive and leap,
Ensuring the storage we keep,
Is tidy, clean, and wonderfully neat!"
🌟🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 93f7a52 and a3af67c.
Files selected for processing (3)
  • s3/README.md (1 hunks)
  • s3/s3_methods.go (1 hunks)
  • s3/s3_methods_test.go (1 hunks)
Additional comments not posted (3)
s3/s3_methods_test.go (1)

21-47: LGTM! The test function Test_S3_DeleteMany correctly implements the logic to test the DeleteMany method, ensuring that keys are deleted as expected and verifying the behavior through assertions.

s3/s3_methods.go (1)

39-63: LGTM! The DeleteMany method is correctly implemented, with proper handling of an empty keys slice, construction of the types.ObjectIdentifier slice, and error handling. This method efficiently facilitates the deletion of multiple S3 objects.

s3/README.md (1)

38-38: LGTM! The documentation correctly includes the DeleteMany method. For enhanced clarity, consider adding an example usage of the DeleteMany method to help users understand how to utilize this new functionality effectively.

Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReneWerner87 ReneWerner87 merged commit 5de7b1b into gofiber:main Apr 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants