Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New storage driver: NATS #1193

Merged
merged 36 commits into from
Feb 7, 2024
Merged

New storage driver: NATS #1193

merged 36 commits into from
Feb 7, 2024

Conversation

cr1cr1
Copy link
Contributor

@cr1cr1 cr1cr1 commented Jan 29, 2024 •
edited by gaby
Loading

@gaby gaby changed the title new storage driver for nats New storage driver: NATS Jan 29, 2024
gaby
gaby reviewed Jan 29, 2024
View reviewed changes
.github/workflows/test-nats.yml Outdated Show resolved Hide resolved
nats/README.md Outdated Show resolved Hide resolved
nats/config.go Outdated Show resolved Hide resolved
nats/config.go Outdated Show resolved Hide resolved
nats/README.md Show resolved Hide resolved
@gaby
Copy link
Member

gaby commented Jan 30, 2024

@cr1cr1 After line 40 of .github/workflows/gosec.yml add this:

dir_names_max_depth: '1'

gaby
gaby reviewed Jan 30, 2024
View reviewed changes
nats/README.md Outdated Show resolved Hide resolved
gaby
gaby reviewed Jan 30, 2024
View reviewed changes
nats/nats.go Outdated Show resolved Hide resolved
gaby
gaby reviewed Jan 30, 2024
View reviewed changes
nats/nats.go Outdated Show resolved Hide resolved
gaby
gaby reviewed Jan 30, 2024
View reviewed changes
nats/config.go Outdated Show resolved Hide resolved
gaby
gaby reviewed Jan 30, 2024
View reviewed changes
nats/nats.go Outdated Show resolved Hide resolved
@gaby
Copy link
Member

gaby commented Jan 30, 2024

@cr1cr1 Thank you, will do a full review within the next day.

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 5, 2024 •
edited
Loading

  • pls add your storage to the README.md in root

ReneWerner87
ReneWerner87 reviewed Feb 5, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member

LGTM
@gaby also ok ?

@gaby
Copy link
Member

gaby commented Feb 5, 2024

LGTM @gaby also ok ?

Looking at it now, i'm not convinced its using TLS. Let me check the docs

gaby
gaby requested changes Feb 5, 2024
View reviewed changes
nats/nats_test.go Show resolved Hide resolved
nats/testdata/nats-tls.conf Show resolved Hide resolved
gaby
gaby reviewed Feb 5, 2024
View reviewed changes
nats/README.md Show resolved Hide resolved
@gaby
Copy link
Member

gaby commented Feb 5, 2024

After those small changes it should be good to go.

gaby
gaby approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReneWerner87 ReneWerner87 merged commit 71ee192 into gofiber:main Feb 7, 2024
13 checks passed
@ReneWerner87
Copy link
Member

https://github.com/gofiber/storage/releases/tag/nats%2Fv1.0.0

@ReneWerner87
Copy link
Member

https://docs.gofiber.io/storage/nats_v1.x.x/nats/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@gaby gaby gaby approved these changes

@sixcolors sixcolors Awaiting requested review from sixcolors

@efectn efectn Awaiting requested review from efectn

Assignees
No one assigned
Labels
✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cr1cr1 @gaby @ReneWerner87