Only show reference cross in TextureProgressBar when the node is selected #99683
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (Engine::get_singleton()->is_editor_hint()) { | ||
| #ifdef TOOLS_ENABLED | ||
| // Draw a reference cross when the node is selected in the editor. | ||
| if (Engine::get_singleton()->is_editor_hint() && EditorNode::get_singleton()->get_editor_selection()->is_selected(this)) { |
There was a problem hiding this comment.
This and the use of EditorNode below is IMO good reasons to add functionality to Node to enforce the separation here
|
As it relies on selection in editor, wouldn't be better adding custom gizmo as suggested in godotengine/godot-proposals#11225 (comment)? And this will be groundwork for more functionality (for example, range editing) which could be added later. |
arkology
reviewed
Nov 25, 2024
Calinou
force-pushed
the
textureprogressbar-reference-when-selected-only
branch
from
f86048a
to
ba1ed9a
Compare
…cted This reduces visual obstruction in the editor. Additionally, the cross' width no longer scales with zoom, improving visibility at high zoom levels.
Calinou
force-pushed
the
textureprogressbar-reference-when-selected-only
branch
from
ba1ed9a
to
90b36f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces visual obstruction in the editor.
Additionally, the cross' width no longer scales with zoom, improving visibility at high zoom levels.
Alternative solution to #99628. This one is simpler - it avoids using an extra internal node which would have a performance cost in scenes with hundreds of TextureProgressBars or more1. It also works more automatically by addressing the original problem at the core (bad visibility when editing pixel art UI), similar to how #75303 works.
I also have an alternate version where the cross has a drop shadow (not included here), but given it's drawn with thin lines, it doesn't look great at high zoom levels since the lines start being separated from each other.
Preview
100% zoom
High zoom level (600% or so)
Footnotes
Even if this is editor-only, it still has an impact when editing scenes in the editor. ↩