Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file dialog all files filter name from All Files (*) to All Files (*.*). #99644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

Change file dialog all files filter name from All Files (*) to All Files (*.*). #99644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/classes/EditorFileDialog.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<method name="clear_filters">
<return type="void" />
<description>
Removes all filters except for "All Files (*)".
Removes all filters except for "All Files (*.*)".
</description>
</method>
<method name="get_line_edit">
Expand Down
2 changes: 1 addition & 1 deletion editor/gui/editor_file_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ void EditorFileDialog::update_filters() {
}
}

String f = TTR("All Files (*)");
String f = TTR("All Files") + " (*.*)";
filter->add_item(f);
processed_filters.push_back("*.*;" + f);
}
Expand Down
4 changes: 2 additions & 2 deletions platform/linuxbsd/freedesktop_portal_desktop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ Error FreeDesktopPortalDesktop::file_dialog_show(DisplayServer::WindowID p_windo
} else {
if (flt == "*.*") {
filter_exts.push_back("*");
filter_names.push_back(RTR("All Files") + " (*)");
filter_names.push_back(RTR("All Files") + " (*.*)");
} else {
filter_exts.push_back(flt);
filter_names.push_back(flt);
Expand All @@ -405,7 +405,7 @@ Error FreeDesktopPortalDesktop::file_dialog_show(DisplayServer::WindowID p_windo
}
if (filter_names.is_empty()) {
filter_exts.push_back("*");
filter_names.push_back(RTR("All Files") + " (*)");
filter_names.push_back(RTR("All Files") + " (*.*)");
}

DBusError err;
Expand Down
2 changes: 1 addition & 1 deletion platform/windows/display_server_windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ void DisplayServerWindows::_thread_fd_monitor(void *p_ud) {
}
if (filter_names.is_empty()) {
filter_exts.push_back(String("*.*").utf16());
filter_names.push_back((RTR("All Files") + " (*)").utf16());
filter_names.push_back((RTR("All Files") + " (*.*)").utf16());
}

Vector<COMDLG_FILTERSPEC> filters;
Expand Down
2 changes: 1 addition & 1 deletion scene/gui/file_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ void FileDialog::update_filters() {
}
}

String f = atr(ETR("All Files")) + " (*)";
String f = atr(ETR("All Files")) + " (*.*)";
filter->add_item(f);
processed_filters.push_back("*.*;" + f);
}
Expand Down