Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LookAtModifier3D adopt the bone name method #99612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make LookAtModifier3D adopt the bone name method #99612

wants to merge 1 commit into from
+69 −9

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 24, 2024 •
edited
Loading

@TokageItLab TokageItLab added this to the 4.4 milestone Nov 24, 2024
@TokageItLab TokageItLab requested a review from a team November 24, 2024 02:33
@TokageItLab TokageItLab requested review from a team as code owners November 24, 2024 02:33
@fire fire changed the title Make LookAtModifier3D adopt to bone name method Make LookAtModifier3D adopt the bone name method Nov 24, 2024
fire
fire approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer bone name over bone index bones because the Ref<Skin> system does not handle bone indices well, and we tried in previous attempts to deprecate the bone index system but could not.

@TokageItLab TokageItLab mentioned this pull request Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:editor
Projects
Animation Team Issue Triage
Status: Approved, Waiting for Production
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Error spam when origin_from equals SpecificBone in LookAtModifier3D
2 participants
@TokageItLab @fire