Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Control class to properly reflect behavior of Themes on Control Children #90289

Closed
wants to merge 2 commits into from

Conversation

tinybitofheaven
Copy link
Contributor

This is a change suggested by #88534.
My apologies for doing this change in the wrong repository sometime earlier.

@tinybitofheaven tinybitofheaven requested a review from a team as a code owner April 6, 2024 04:11
@Chaosus Chaosus added this to the 4.3 milestone Apr 6, 2024
Co-authored-by: A Thousand Ships <[email protected]>
@mhilbrunner
Copy link
Member

Thanks for contributing :) The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

@tetrapod00
Copy link
Contributor

Closing as superseded by #99620.

I went ahead and made a new PR which squashed your commits and also made a couple other improvements. You are credited as a co-author on the new PR's commit. Thank you for your contribution!

@tetrapod00 tetrapod00 closed this Nov 25, 2024
@AThousandShips AThousandShips removed this from the 4.4 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants