Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable copy protection for input and textarea fields. #2791

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

ideadude
Copy link
Member

@ideadude ideadude commented Nov 1, 2024

Description

The copy protection Javascript has been updated to exclude INPUT and TEXTAREA elements. This will allow users to copy email and address fields and other things in text boxes that typically don't need to have copy protection.

How has this been tested?

Manually. Go to the checkout page. Try to copy some text on the page. You will instead have "Copying is not allowed." your clipboard. Now type something into the email field and try to copy that. You will have the actual copied text.

I haven't tested this yet. There is a unit test related to the copy protection feature. It may fail now. We can think about updating or removing that test.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg added this to the Next Available Release milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

2 participants