Skip to content

Commit

Permalink
Rename l10n (i18n internationalization / localization) js script (#2789)
Browse files Browse the repository at this point in the history
* Renaming file in case a security scanner is picking it up incorrectly.
* Making non-required file include vs. require.
  • Loading branch information
brianhogg authored Oct 31, 2024
1 parent 1ac9813 commit 3187dc3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .changelogs/rename-l18n-js-script.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
significance: patch
type: fixed
links:
- "#2787"
entry: Renaming front-end javascript translation file not required, as some
security scans appear to be deleting it incorrectly.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ assets/js/*.min.js
assets/js/llms-metaboxes.js
blocks/certificate-title/*
blocks/my-account/*
includes/class.llms.l10n.js.php
includes/class.llms.l10n.frontend.php
languages/lifterlms.pot

# Ignore composer-installed libs.
Expand Down
2 changes: 1 addition & 1 deletion .llmsconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"domain": "lifterlms",
"dest": "languages/",
"jsClassname": "LLMS_L10n_JS",
"jsFilename": "class.llms.l10n.js.php",
"jsFilename": "class.llms.l10n.frontend.php",
"jsSince": "3.17.8",
"jsSrc": [ "assets/js/**/*.js", "!assets/js/**/*.min.js", "!assets/js/**/*.js.map" ],
"lastTranslator": "Thomas Patrick Levy <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion includes/class-llms-loader.php
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ public function includes() {
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.comments.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.date.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.install.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.l10n.js.php';
include_once LLMS_PLUGIN_DIR . 'includes/class.llms.l10n.frontend.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.nav.menus.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.oembed.php';
require_once LLMS_PLUGIN_DIR . 'includes/class.llms.playnice.php';
Expand Down

0 comments on commit 3187dc3

Please sign in to comment.