Skip to content

Commit

Permalink
Move rack and rackup into dev/test block
Browse files Browse the repository at this point in the history
  • Loading branch information
tschafer-gc committed Nov 14, 2024
1 parent 5120219 commit a2c331f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
fail-fast: false
matrix:
ruby_version: ["3.0", "3.1", "3.2", "3.3"]
rack_version: ["2.2", "3.1"]
rack_version: ["2.2.5", "3.1"]
runs-on: ubuntu-latest
services:
postgres:
Expand Down
16 changes: 8 additions & 8 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ group :development, :test do
gem 'rubocop-rspec', '~> 3.0.2'
gem 'rubocop-sequel', '~> 0.3.4'
gem 'sequel', require: nil

rack_version = ENV.fetch('RACK_VERSION', "3.1")
gem "rack", rack_version
if Gem::Version.new(rack_version) < Gem::Version.new('3.0.0')
gem "rackup", "~> 1.0"
else
gem "rackup", "~> 2.0"
end
end

group :test do
Expand All @@ -25,14 +33,6 @@ group :test do
gem 'rspec', '~> 3.9'
end

rack_version = ENV['RACK_VERSION'] || "3.0"
gem "rack", rack_version
if Gem::Version.new(rack_version) < Gem::Version.new('3.0.0')
gem "rackup", "~> 1.0"
else
gem "rackup", "~> 2.0"
end

gem 'prometheus-client', '~> 1.0'
source "https://rubygems.pkg.github.com/gocardless" do
gem "prometheus_gcstat"
Expand Down

0 comments on commit a2c331f

Please sign in to comment.