Support using repo configuration from a branch #81

…mod (runatlantis#3640) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: Omit repos from allowlist * Add quote in comment * Better comment * Remove test

Problem When `projects` are specified and `when_modified` is not specified via the config file, changing `.terraform.lock.hcl` file won't trigger auto plan. This is because the default `raw.WhenModified` does not include `.terraform.lock.hcl`. Note that when projects are auto detected, changing `.terraform.lock.hcl` triggers auto plan. This is because the `cmd.DefaultAutoplanFileList` includes `.terraform.lock.hcl`. Solution Include `.terraform.lock.hcl` to the default `raw.WhenModified`.

…antis#3636) * Update server/events/working_dir logging * Add e2e FileWorkspace logger * Fix github app working dir test logger * Update working_dir_test --------- Co-authored-by: Dylan Page <[email protected]>

While using a PR from a fork and the "Github allow mergeable bypass apply" flag, the mergeable checks were run with the wrong owner in the request, leading to 404. By choosing the owner from the head repo data it should work both, for fork PRs and in-repo PRs. Co-authored-by: Dylan Page <[email protected]>

runatlantis#3642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…antis#3643) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… Changes` (runatlantis#3378) * mod: rename updateCommitStatus func * feat: add PlannedNoChangesPlanStatus * Add skipApplyNoChanges option to PlanCommandRunner * Add skipApplyNoChanges option to ApplyCommandRunner * Add --skip-apply-no-changes flag * Fix typo Co-authored-by: nitrocode <[email protected]> * Rename --skip-apply-no-changes flag * Refactor updateCommitStatus functions * chore(docs): add detailed use case for the flag * test: add plan_command_runner set apply status * feat: set apply status to successful by default when result is 'No Changes' --------- Co-authored-by: chroju <[email protected]> Co-authored-by: nitrocode <[email protected]>

…ty (runatlantis#3428) In this particular example `mr.HeadPipeline.SHA` panics on a nil pointer dereference because HeadPipeline is empty. This seems to be caused by the lack of permission to update the commit status. ```go runtime.gopanic runtime/panic.go:1038 runtime.panicmem runtime/panic.go:221 runtime.sigpanic runtime/signal_unix.go:735 github.com/runatlantis/atlantis/server/events/vcs.(*GitlabClient).PullIsMergeable github.com/runatlantis/atlantis/server/events/vcs/gitlab_client.go:208 github.com/runatlantis/atlantis/server/events/vcs.(*ClientProxy).PullIsMergeable github.com/runatlantis/atlantis/server/events/vcs/proxy.go:72 github.com/runatlantis/atlantis/server/events/vcs.(*pullReqStatusFetcher).FetchPullStatus github.com/runatlantis/atlantis/server/events/vcs/pull_status_fetcher.go:28 github.com/runatlantis/atlantis/server/events.(*ApplyCommandRunner).Run github.com/runatlantis/atlantis/server/events/apply_command_runner.go:105 github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand github.com/runatlantis/atlantis/server/events/command_runner.go:252 ``` The least invasive solution is to simply use the commit-hash from pull and guess that the pipeline was "skipped" unless the HeadPipeline is there. The outcome is: When mr.HeadPipeline is present: - use the commit hash and status from the HeadPipeline When mr.HeadPipeline is NOT present: - use the commit hash from pull request struct - assume the pipeline was "skipped" In cases where GitLab is configured to require a pipeline to pass, this results on a message saying the MR is not mergeable. More info: - runatlantis#1852

* Fix Go Static Checks * Fix working dir tests

…os/workspace-configured/main.tf (runatlantis#3655) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…lantis#3656) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix golang-ci * Update lint workflows * Removed required checks

* fix: gitlab client failing test * change HeadCommit to `67cb91d3f6198189f433c045154a885784ba6977` * remove test case for now

…t to f15f31b in go.mod (runatlantis#3658) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3650) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.15.0 in go.mod (runatlantis#3654) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3647) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3652) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… in go.mod (runatlantis#3659) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…leci/config.yml (runatlantis#3660) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…atlantis#3661) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update to use go1.21 Signed-off-by: Rui Chen <[email protected]> * update go base image to 1.21.0 --------- Signed-off-by: Rui Chen <[email protected]>

…in go.mod (runatlantis#3662) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…os/workspace-configured/main.tf (runatlantis#3668) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ableBypassApply with no required checks on branch protection (runatlantis#3672) * Implement test for allow mergeable bypass apply with no branch protection checks * Report true combined status if no branch protection required status checks * Remove warning on feature flag utilization

….mod (runatlantis#3676) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#3677) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…os/workspace-configured/main.tf (runatlantis#3689) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…#3691)

…0.15.1 in go.mod (runatlantis#3683) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3685) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#3694) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add ability to send slack notification matched on base branch name * Update BranchRegex usage doc * Add test with invalid branch and workspace regex

…go.mod (runatlantis#3696) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#3695) By fixing nil pointer reference in 3428 we unveiled yet another bug now that the code is able to run further: When an MR with no HeadPipeline exists its commits are set to skipped by default and thus create some mess when running "PullMergeable" (rendering the MR useless) The bug was caught by the tests, however, in an attempt to make the build pass and unblock we create a patch to ignore that test. In order to prevent further problems, this MR: * Updates the test stack to run all plan/apply commands in the context of "HeadLess" Pipelines * Fixes the default of skipped pipeline to false (as it is better to assume it is NOT skipped since that prevents the merge in most cases) * Make all integratiion tests pass References: * Original MR: runatlantis#3428 * Tests Patch MR : runatlantis#3653

…leci/config.yml (runatlantis#3700) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… in go.mod (runatlantis#3702) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…t to b800820 in go.mod (runatlantis#3704) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…od (runatlantis#3705) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…os/workspace-configured/main.tf (runatlantis#3707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: fix typo precidence -> precedence * docs: markdown fmt pass

…2.0.0-beta.67 in package.json (runatlantis#3716) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.15.3 in go.mod (runatlantis#3719) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3726) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… Errors (runatlantis#3729) * FailOnPreWorkflowHookError * Fix linting issues

…3728) Added information how to obtain `--gh-app-slug` value form installed app

…in dockerfile (runatlantis#3730) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in testing/dockerfile (runatlantis#3732) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3733) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3735) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3737) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…s/website.yml (runatlantis#3738) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ate (runatlantis#3744) * Change message for when request is not approved * Updates * Fix * Fix tests

….mod (runatlantis#3743) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#3746) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…55 in go.mod (runatlantis#3743)" (runatlantis#3748) This reverts commit 3a2a244.

…unatlantis#3675)

…leci/config.yml (runatlantis#3753) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…os/workspace-configured/main.tf (runatlantis#3759) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tory to be Deleted (runatlantis#3751) * Running 'atlantis unlock' on a PR Causes The Whole Working Directory to be Deleted * Update events controller tests * Fix events controller tests --------- Co-authored-by: PePe Amengual <[email protected]>

) * Add portability to command invocation unit tests * Fix linting

…unatlantis#3755) * docs(using-atlantis): add usage for -destroy flag in atlantis plan Signed-off-by: Abdulla Mulail Mohamed <[email protected]> * docs(using-atlantis): add closing to caution note Signed-off-by: Abdulla Mulail Mohamed <[email protected]> * Update runatlantis.io/docs/using-atlantis.md Co-authored-by: PePe Amengual <[email protected]> * Update runatlantis.io/docs/using-atlantis.md Co-authored-by: PePe Amengual <[email protected]> * chore(atlantis): add example Signed-off-by: Abdulla Mulail Mohamed <[email protected]> --------- Signed-off-by: Abdulla Mulail Mohamed <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

…o v2.7.0 in go.mod (runatlantis#3760) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…workflows/testing-env-image.yml (runatlantis#3762) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.15.4 in go.mod (runatlantis#3763) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…lows/testing-env-image.yml (runatlantis#3766) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…antis#3768) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…rkflows/atlantis-image.yml (runatlantis#3771) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…b/workflows/testing-env-image.yml (runatlantis#3772) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…workflows/testing-env-image.yml (runatlantis#3773) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…hub/workflows/release.yml (runatlantis#3774) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ns, imports, and state removals (runatlantis#3776)

…atlantis#3779) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3786) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: Add use plugin cache bool flag * feat: Added use-plugin-cache doc * feat: refactor to reflect terrafrom in plugin cache flag Co-authored-by: Simon Heather <[email protected]> * fix: missing closing in bash block documentation * fix: typo in flag example * feat: improve docs * feat: performance implications documented * feat: increase terraform minor version to 1.3.10 --------- Co-authored-by: Simon Heather <[email protected]>

…unatlantis#3747) * Do not unnecessarily create apply pipeline if it doesn't exist yet * Updates * Fix remaining * Fix test logic * Cleanup more tests * Fix test --------- Co-authored-by: PePe Amengual <[email protected]>

* feat: disable autoplan label * documentation * revert unrelated change * fix property * gitlab and github * dd more test * small fixes * add tests for github and gitlab clients * fix: remove unrelated comments * fmt --------- Co-authored-by: PePe Amengual <[email protected]>

* Safer handling of merging with an updated upstream. We used to call forceClone() to update with upstream, but this deletes the checked out directory. This is inefficient, can delete existing plan files, and is very surprising if you are working manually in the working directory. We now fetch an updated upstream, and re-do the merge operation. This leaves any working files intact. * Rename SafeToReClone -> CheckForUpstreamChanges It's never safe to clone again. But sometimes we need to check for upstream changes to avoid reverting changes. The flag is now used to know when we need to merge again non-destructively with new changes. * Update fixtures.go * Add test to make sure plans are not wiped out As long as the branch itself has not been updated, plans should be kept. Even if upstream has changed. * renamed HasDiverged to MergedAgain in PlanResult and from Clone() This flag was only set to true in case a call to Clone() ended up merging with an updated upstream, so the new name better represents what it means. * Test that Clone on branch update wipes old plans This complements the test that Clone with unmodified branch but modified upstream does _not_ wipe plans. * runGit now runs git instead of returning a function that runs git * Updated template to merged again instead of diverged This is no longer a warning, but expected behavior in merge chekout mode * Rename git wrapper to wrappedGit, add a type for static config Every call to wrappedGit for the same PR uses identical setup for directory, head repo and PR, so passing the --------- Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

…unatlantis#3679) * Fix issue with GH App credential not writing if lines already exist * Fix lint issue of unused variable. --------- Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Dylan Page <[email protected]>

…t to 5a6f8d1 in go.mod (runatlantis#3792) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3794) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3798) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…lantis#3801) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… in go.mod (runatlantis#3803) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in dockerfile (runatlantis#3805) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in testing/dockerfile (runatlantis#3809) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…0.15.5 in go.mod (runatlantis#3808) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3813) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#3818) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Allow DEFAULT_CONFTEST_VERSION and DEFAULT_TERRAFORM_VERSION in alpine image * update go image to pass build test --------- Co-authored-by: Damien Sonney <[email protected]>

….mod (runatlantis#3819) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tis#3708) * Add Workflow hook target filter * Fix post workflow hook example * Update WokrflowHook in global_cfg * Fix linting --------- Co-authored-by: PePe Amengual <[email protected]>

* feat: implemented the code for the depends on functionnality * chore: Address PR comments --------- Co-authored-by: Luay-Sol <[email protected]>

…ntis#3765) * Adding new flag everywhere relevant, implementing policy result workaround * Fixing unit test str matching, adding custom policy conditional to step_runner * Adding documentation steps for custom policy tools * Refactoring ConftestOutput attribute to PolicyOutput

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.29 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.29...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lantis#3802) * Rename arguments in mocked functions from result to res The code generated by pegomock is broken if any of the arguments to the mocked function are named "result", so they must be named something else. * Regenerate all mocks with make go-generate The mocks now work without further modification after running go-generate.

runatlantis#3825) This reverts commit cf2b791.

* Make code more Go-idiomatic While at it makes it more readable. Signed-off-by: Leandro López (inkel) <[email protected]> * Add internal function to parse multienv step input This new function properly deals with quotes and commas in values. Signed-off-by: Leandro López (inkel) <[email protected]> * Add regression test for multienv output with comma in values See runatlantis#2765 for an issue report. Signed-off-by: Leandro López (inkel) <[email protected]> * Use parseMultienvLine for parsing multienv steps output Signed-off-by: Leandro López (inkel) <[email protected]> * Add internal function to parse multienv step input This new function properly deals with quotes and commas in values. Signed-off-by: Leandro López (inkel) <[email protected]> --------- Signed-off-by: Leandro López (inkel) <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

* Adding new flag everywhere relevant, implementing policy result workaround * Fixing unit test str matching, adding custom policy conditional to step_runner * Adding documentation steps for custom policy tools * Refactoring ConftestOutput attribute to PolicyOutput * Adding new flag everywhere relevant, implementing policy result workaround * Fixing unit test str matching, adding custom policy conditional to step_runner * Adding documentation steps for custom policy tools * Refactoring ConftestOutput attribute to PolicyOutput * Fixing custom policy docs typo * End spacing

…unatlantis#3828) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3831) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3833) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

When the underlying GitHub Client returns an error it gets swallowed in this wrapper method. Not only that but also the emitted metrics are wrong, as it counts one error AND success at the same time. We've found this @grafana when using Atlantis in a massive repository with many changes per minute, and sometimes Atlantis leave a comment saying it's automatically merging but then nothing happens. But checking the logs, we've found the following error message: Unable to merge pull, error: merging pull request: PUT https://api.github.com/repos/grafana/redacted/pulls/666/merge: 405 Base branch was modified. Review and try the merge again. [] And because the error is swallowed and `InstrumentedClient.MergePull` returns `nil`, then `Automerger` fails to leave a comment saying merging failed.

…mod (runatlantis#3840) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: PePe Amengual <[email protected]>

…tis#3837) Co-authored-by: PePe Amengual <[email protected]>

* Added disable-unlock-label config option * Fixed tests * Wrote tests + fixed mistakes * Added docs * added defaults to docs --------- Co-authored-by: PePe Amengual <[email protected]>

…atlantis#3842) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#3843) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…natlantis#3849) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…6 in go.mod (runatlantis#3854) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…atlantis#3857) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ntis#3859) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in go.mod (runatlantis#3861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…leci/config.yml (runatlantis#3860) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Signed-off-by: Rui Chen <[email protected]>

…tis#2975) update condition Signed-off-by: Rui Chen <[email protected]>

* add misspell check * lint: fix misspell issues ``` server/events/vcs/instrumented_client.go:46:26: `soley` is a misspelling of `solely` (misspell) // methods and implement soley any github specific interfaces. ^ server/events/project_command_context_builder.go:49:5: `Conciously` is a misspelling of `Consciously` (misspell) // Conciously making this global since it gets flushed periodically anyways ^ server/controllers/events/gitlab_request_parser_validator.go:87:32: `noteable` is a misspelling of `notable` (misspell) NoteableType string `json:"noteable_type"` ^ server/controllers/events/gitlab_request_parser_validator_test.go:351:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "MergeRequest", ^ server/controllers/events/gitlab_request_parser_validator_test.go:359:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": 7, ^ server/controllers/events/gitlab_request_parser_validator_test.go:467:6: `noteable` is a misspelling of `notable` (misspell) "noteable_type": "Commit", ^ server/controllers/events/gitlab_request_parser_validator_test.go:475:6: `noteable` is a misspelling of `notable` (misspell) "noteable_id": null, ^ server/events/event_parser_test.go:1012:23: `seperate` is a misspelling of `separate` (misspell) // If sha changes in seperate PR, ^ ``` Signed-off-by: Rui Chen <[email protected]> * add locale setting Signed-off-by: Rui Chen <[email protected]> * Revert "lint: fix misspell issues" This reverts commit 7cc56af. * lint: fix some misspell issues Signed-off-by: Rui Chen <[email protected]> --------- Signed-off-by: Rui Chen <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

….mod (runatlantis#3869) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…o v2.8.0 in go.mod (runatlantis#3871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…leci/config.yml (runatlantis#3872) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3878) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Improve GitHub and GitLab Debug Logging * Fix formatting * Fix g.client.Repositories.Get debug message * Update gitlab_client_test with logger --------- Co-authored-by: PePe Amengual <[email protected]>

…ction on manually creating a GitHub app and using it with Atlantis. Add notes on differences with the app created by Atlantis (runatlantis#3882) Signed-off-by: snorlaX-sleeps <[email protected]> Committer: snorlaX-sleeps <[email protected]>

…mod (runatlantis#3890) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ows/website.yml (runatlantis#3892) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3896) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…antis#3901) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#3902) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#3906) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… test (runatlantis#3907) * fix: Better determine number of expected comments and webhooks in e2e test * Cleanup

…leci/config.yml (runatlantis#3910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

https://github.com/googleapis/repo-automation-bots/tree/main/packages/cherry-pick-bot#configuring

…rty (runatlantis#3887) * Fix GitLab Mulitple Pipelines * Add logger to tests and fix test ref * Add retry to GetMergeRequest * Update retries --------- Co-authored-by: PePe Amengual <[email protected]>

… Hooks, the PR will be Merged Prematurely (runatlantis#3880) * Fix Premature Auto-Merge * Add CommitStatusUpdater to commandRunner

…0.16.0 in go.mod (runatlantis#3920) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#3921) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor(ci): builds upon work in tests to reduce complexity in requiring workflows * fix: tweaks and missing outputs * fix: make sure the new workflows actually run * fix: consistency with non-required testing image

….mod (runatlantis#3926) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#3927) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(renovate): This fixes renovate to also autoMerge fixes to our release branches so we don't have to cherry-pick them. * fix(renovate): run config validator on release branches too

…d7dfd1b in go.mod (runatlantis#3928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#3963) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: use Atlantis user by default and get rid of gosu * chore: set `DOCKER_CONTENT_TRUST=1` * chore: fix chmod and chown * feat: add a healthcheck to the debian and alpine images * feat: removing setuid and setgid permissions prevents container privilege escalation and improve comments * chore: remove setgid/setuid as we chown an entire directory * chore: keep deps comment generic * chore: grammar * chore: remove redundant comment * chore: rm DOCKER_CONTENT_TRUST * chore: set uid and gid and remove passwd entry * chore: revert gid and uid set as it's conflicting --------- Co-authored-by: PePe Amengual <[email protected]>

…lantis#3966)

Co-authored-by: PePe Amengual <[email protected]>

….mod (runatlantis#3967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3968) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…2.0.0-beta.68 in package.json (runatlantis#3971) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#3972) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…mod (runatlantis#3978) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Signed-off-by: Felipe Zipitria <[email protected]> Co-authored-by: Felipe Zipitria <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

* Check user permissions on autoplan --------- Co-authored-by: PePe Amengual <[email protected]>

Co-authored-by: PePe Amengual <[email protected]>

…tis#3881) We should use `(*regexp.Regexp).MatchString` instead of `(*regexp.Regexp).Match([]byte(...))` when matching string to avoid unnecessary `[]byte` conversions and reduce allocations. Example benchmark: func BenchmarkMatch(b *testing.B) { for i := 0; i < b.N; i++ { if match := branchRegex.Match([]byte("main")); !match { b.Fail() } } } func BenchmarkMatchString(b *testing.B) { for i := 0; i < b.N; i++ { if match := branchRegex.MatchString("main"); !match { b.Fail() } } } goos: linux goarch: amd64 pkg: github.com/runatlantis/atlantis/server/core/config cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics BenchmarkMatch-16 8269699 141.4 ns/op 4 B/op 1 allocs/op BenchmarkMatchString-16 14298446 95.81 ns/op 0 B/op 0 allocs/op PASS ok github.com/runatlantis/atlantis/server/core/config 2.784s Signed-off-by: Eng Zer Jun <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

…leci/config.yml (runatlantis#3981) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: PePe Amengual <[email protected]>

…2.0.0-rc.0 in package.json (runatlantis#3986) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* add flag to allow the user disable the autodiscover * add global config and doc * feat: Implement autodiscover.mode * fix: Minor doc fixes * fix: Small fixes to docs/indent/tests * fix: Line length, quoting, function comments * fix: Add a few more tests and remove newlines * fix: Always camel case never snake --------- Co-authored-by: Marcelo Medeiros <[email protected]> Co-authored-by: nitrocode <[email protected]> Co-authored-by: PePe Amengual <[email protected]>

…o.mod (runatlantis#4006) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…lantis#4008) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…leci/config.yml (runatlantis#4009) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…atlantis#4010) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…t to a34142e in go.mod (runatlantis#4014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Signed-off-by: Rui Chen <[email protected]>

runatlantis#4015) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in testing/dockerfile (runatlantis#4017) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#4018) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ing (runatlantis#3996) * fix: removing mr.Headpipeline.Source log when mr.HeadPipeline is missing * fix: remove mr.HeadPipeline.Source from other log

* fix: Relax constraint for installing curl * Update Dockerfile

…unatlantis#4020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…lantis#4021) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#4026) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump vite from 4.4.9 to 4.4.12 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.4.9 to 4.4.12. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.4.12/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.4.12/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * fix gitlab approvals links Signed-off-by: Rui Chen <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Rui Chen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Rui Chen <[email protected]>

…s/release.yml (runatlantis#4027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tale.yml (runatlantis#4031) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(atlantis): fix linter errors * fix superfluous-else * revert gitlab check * ignore stub funcs on azuredevops_client * remove fetch-depth * remove fail_on_error * fix plan_step_runner_test.go * more lint fixes --------- Co-authored-by: Dylan Page <[email protected]>

Autoplan would set the "policy_check" status to successful if there were no modified projects in a PR, but "atlantis plan" would not. Changed "atlantis plan" to behave like autoplan in this regard.

* feat: implemented the code for the depends on functionality Co-authored-by: Vincent <[email protected]>

….mod (main) (runatlantis#4032) * fix(deps): update module github.com/google/go-github/v54 to v57 in go.mod * fix(deps): go-github v57 in server/events/vcs/testdata/fixtures.go --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: nitrocode <[email protected]>

* fix: clone repository before getting working dir * unrelated change * move TryLock up * fix workspace and add e2e tests * fix description --------- Co-authored-by: PePe Amengual <[email protected]>

* fix: fetch before checking status * Switch to fetch

* Add code for disabling apply flag * Better comment

* Update using-atlantis.md I was having problems with `atlantis apply` when I wanted to apply all pending plans. The problem was that every time I tried to execute this action, I got "Ran Apply for 0 projects:" because atlantis, for the apply action, did not know where the tfstates were. I think this is something that we can add in the documentation, because I did not find this clarification The problem was that every time I tried to execute this action, I was getting "Ran Apply for 0 projects:" due to atlantis, for the apply action, didn’t know where the tfstates were located. I think it's something we can add in the documentation, because I didn’t find this aclaration * Update runatlantis.io/docs/using-atlantis.md --------- Co-authored-by: PePe Amengual <[email protected]>

* feat: better logging for UpdateStatus * feat: jobs now shown in a table in the main page --------- Co-authored-by: PePe Amengual <[email protected]>

…ntis#3863)

…be Re-Applied on the Same Commit (runatlantis#4007) * Fix GitLab CI Must Pass * Fix projectID * nolint:staticcheck * nolint:gosec * Fix formatting --------- Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Dylan Page <[email protected]>

* Enforce policy checks for overriden apply reqs * Another take on the fix This new version only includes the 'policies_passed' req back if policy checks are enabled for the project. * Fix test * Fix comment * Fix spelling --------- Co-authored-by: PePe Amengual <[email protected]>

* Remove option to allow repo * Fix internal test * Fix fmt * Fmt * Fix rebase --------- Co-authored-by: PePe Amengual <[email protected]> Co-authored-by: Dylan Page <[email protected]>

….mod (runatlantis#4035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

When files of the default branch is the same as files of a tag, dorny/paths-filter does not detect changes and no new images are pushed. Co-authored-by: PePe Amengual <[email protected]>

…unatlantis#4045) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

It seems that GitHub has changed its Markdown renderer such that an emoji followed by a string of plain text (with no other formatting) followed by a colon at the end of the line renders as plain text instead of as the emoji. Compare the following two lines: * 🚮 To delete all plans and locks for the PR, comment: * 🚮 To **delete** all plans and locks for the PR, comment: While this seems like it is probably a GitHub bug, we can work around it by adding some formatting between the emoji and the end of the line, which matches the bullet point above it anyway.

fix mergeAgain function for when the PR is created from a fork

runatlantis#4055) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Updating curl * Updating docs for custom image * Updating docs for custom image * fixing note * some style change * Update runatlantis.io/docs/deployment.md Co-authored-by: Rui Chen <[email protected]> --------- Co-authored-by: Rui Chen <[email protected]>

…flows/codeql.yml (runatlantis#4059) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…leci/config.yml (runatlantis#4056) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…unatlantis#4073) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tis#4072) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0. - [Commits](golang/crypto@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: add governance process to Atlantis * docs: update release process and add backport steps * docs: tweaks * Update GOVERNANCE.md Co-authored-by: Rui Chen <[email protected]> * Update GOVERNANCE.md Co-authored-by: Rui Chen <[email protected]> * docs: review suggestions --------- Co-authored-by: Rui Chen <[email protected]>

Updating alongside the GOVERNANCE update to add the new core-contributors team for code reviews.

…ntis#4078) Signed-off-by: Jack Andersen <[email protected]>

….mod (runatlantis#4079) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ntis#4084) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…#4086) * feat: Move gitlab client test data into testdata/ files * Cleanup

…itlab client (runatlantis#4082) Fix potential nil pointers. See runatlantis#4081 for context.

…mod (runatlantis#4028) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update server-side-repo-config.md Update document for Metric on repo config * docs(server-side-repo-config): fix case Co-authored-by: Luke Massa <[email protected]> --------- Co-authored-by: Rui Chen <[email protected]> Co-authored-by: Luke Massa <[email protected]>

* download conftest binary for correct arch Signed-off-by: Prajith P <[email protected]> * remove default constant Signed-off-by: Prajith P <[email protected]> --------- Signed-off-by: Prajith P <[email protected]>

…unatlantis#4047) * Remove settings for require approval, mergeable, undiverged * Fix

…c.0 in package.json (runatlantis#3970) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ed` (runatlantis#4105) * Update runatlantis.io/docs/server-configuration.md * runatlantis.io/docs/command-requirements.md * Update server-configuration.md

…us Plan Comments (runatlantis#4012) * Fix Hide Previous Plan Comments * Update GitLab client tests * Update GitLab client test * Update github client test * Add nolint: errcheck to test * format github_client.go

…in go.mod (runatlantis#4118) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…in testing/dockerfile (runatlantis#4120) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…o v2.9.0 in go.mod (runatlantis#4124) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…tlantis#4126) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….mod (runatlantis#4127) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

runatlantis#4135) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…atlantis#4136) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

@ijames-gc

Instead of using the atlantis.yaml file present in the pull request branch, allow users to specify a branch that contains an approved version of atlantis.yaml. This allows enabling things like approval requirement overrides for repo config, while ensuring a user can't simply change the configuration to drop an approval requirement in the branch they're currently working on. An example would be creating a server-side configuration like this: ```yaml --- repos: - id: github.com/gocardless/app apply_requirements: [approved, mergeable] allowed_overrides: [apply_requirements, workflow] allow_custom_workflows: false config_source_branch: master workflows: lab: plan: steps: - init - plan: extra_args: [-var-file, lab.tfvars] prd: plan: steps: - init - plan: extra_args: [-var-file, prd.tfvars] ``` Specifying a rigid workflows that become all that is available to run in gocardless/app. Now the application (gocardless/app) would create an atlantis.yaml at the root of the repo, like so: ``` --- version: 2 projects: - dir: terraform/google/projects/apps apply_requirements: [] workspace: lab workflow: lab - dir: terraform/google/projects/apps apply_requirements: [approved] workspace: prd workflow: prd ``` Because config_source_branch is set to master, when someone creates a PR against gocardless/apps, the atlantis.yaml that specifies whether a project has an approved apply_requirement is from the master branch. As is a common pattern, merging to master is protected by an authorised code-review, allowing us to have two types of environment for this project: - lab, where you can plan and apply without approval - prd, where you can only apply once the PR is approved @ijames-gc: - Added tests: - Add TestClone_FetchAdditionalBranches - Add TestDefaultProjectCommandBuilder_ConfigSourceBranch - Refactor checkout logic - Update docs Co-authored-by: Lawrence Jones <[email protected]> Co-authored-by: Dyson Simmons <[email protected]> Co-authored-by: Dragos Dumitrache <[email protected]>

Atlantis server requires a default tf version, however, this setting here also has the side effect to have a default version in utopia terraform. This is not safe, as you might updating the tf state version by mistake. Move this setting to the atlantis runtime config, so we check and run only the relevant terraform version in case of manual intervention

This ensures we're not running our CI against the head of the repository branch Also enable workflow_dispatch

runatlantis#4216) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support using repo configuration from a branch #81

Support using repo configuration from a branch #81

Commits on Feb 13, 2024