Update fizz.md create_table details #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fizz.md to match the recent changes to the create_table method from gobuffalo/fizz#15.
kteb
reviewed
Aug 29, 2018
| @@ -35,7 +37,7 @@ create_table("users") { | |||
| } | |||
| ``` | |||
|
|
|||
| It will also generate two `timestamp` columns; `created_at` and `updated_at`. | |||
| Note that a primary key is not required. The `create_table` function will generate two `timestamp` columns; `created_at` and `updated_at`. | |||
There was a problem hiding this comment.
It's not needed for fizz, but I think it's needed for buffalo (so when using buffalo it'll be created, if so it might be good to precise it). Am I wrong @stanislas-m ?
There was a problem hiding this comment.
Pop will still generate an ID, even if fizz doesn't require it. Fizz had its rule loosen because it can be used outside Pop scope, and requiring an ID is a Pop rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
fizz.mdto match the recent changes to thecreate_tablemethod from gobuffalo/fizz#15; auto-incrementing primary keys are no longer automatically created by thecreate_tablemethod.