Fix assets helpers

* Fix #921: use webpack publicPath, instead of hard-coded "/assets/".
gobuffalo · Apr 14, 2018 · b5ea198 · b5ea198
1 parent e8adcbf
commit b5ea198
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/generators/assets/webpack/templates/webpack.config.js.tmpl b/generators/assets/webpack/templates/webpack.config.js.tmpl
@@ -75,7 +75,7 @@ const configurator = {
     var config = {
       mode: env,
       entry: configurator.entries(),
-      output: {filename: "[name].[hash].js", path: `${__dirname}/public/assets`},
+      output: {filename: "[name].[hash].js", path: `${__dirname}/public/assets`, publicPath: "/assets/"},
       plugins: configurator.plugins(),
       module: configurator.moduleOptions()
     }

diff --git a/render/template_helpers.go b/render/template_helpers.go
@@ -27,9 +27,9 @@ func assetPathFor(file string) string {
 
 	filePath := assetMap[file]
 	if filePath == "" {
-		filePath = file
+		filePath = filepath.Join("/assets", file)
 	}
-	return filepath.ToSlash(filepath.Join("/assets", filePath))
+	return filepath.ToSlash(filePath)
 }
 
 type helperTag struct {