Rocket Pool Dashboard List #1161
Open
+314
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
ff633d8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1945044.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-981-rocketpool-dashboar.beaconchain.pages.dev |
manuelsc
force-pushed
the
BEDS-981/rocketpool-dashboard
branch
from
4358dae
to
b5b3ad7
Compare
perf: use new validator index for rocket pool mobile queries instead of pubkey
manuelsc
force-pushed
the
BEDS-981/rocketpool-dashboard
branch
from
b5b3ad7
to
ff633d8
Compare
remoterami
reviewed
Nov 28, 2024
Comment on lines
400
to
+407
| status, | ||
| rn.smoothing_pool_opted_in | ||
| rn.smoothing_pool_opted_in, | ||
| validator_index | ||
| FROM rocketpool_minipools | ||
| LEFT JOIN rocketpool_nodes rn ON rocketpool_minipools.node_address = rn.address | ||
| WHERE pubkey = ANY($1) | ||
| WHERE validator_index = ANY($1) | ||
| ` | ||
| err := d.alloyReader.SelectContext(ctx, &rocketPoolResults, validatorsQuery, pq.ByteaArray(pubKeys)) | ||
| err := d.alloyReader.SelectContext(ctx, &rocketPoolResults, validatorsQuery, indices) |
There was a problem hiding this comment.
This query could probably be merged with the call to GetValidatorDashboardValidators, I'm not the biggest fan of passing (potentially large) validator arrays around via ANY().
But I can see how that's a lot of effort, so prob only worth doing once we hit perf issues
| if cursor != "" { | ||
| currentCursor, err = utils.StringToCursor[t.RocketPoolCursor](cursor) | ||
| if err != nil { | ||
| return nil, &paging, fmt.Errorf("failed to parse passed cursor as ValidatorsCursor: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, &paging, fmt.Errorf("failed to parse passed cursor as ValidatorsCursor: %w", err) | |
| return nil, &paging, fmt.Errorf("failed to parse passed cursor as RocketPoolCursor: %w", err) |
| goqu.L("COUNT(mp.address) as minipools_total"), | ||
| goqu.L("SUM(CASE WHEN mp.node_deposit_balance = 8e18 THEN 1 ELSE 0 END) AS minipools_leb8"), | ||
| goqu.L("SUM(CASE WHEN mp.node_deposit_balance = 16e18 THEN 1 ELSE 0 END) AS minipools_leb16"), | ||
| goqu.L("CASE WHEN COUNT(mp.address) > 0 THEN SUM(mp.node_fee) / COUNT(mp.address) ELSE 0 END AS avg_commission"), |
There was a problem hiding this comment.
check: Should the average commission only factor in Staking minipools? Depending on how the data is used. Also this could be weighted by the amount of borrowed ETH per MP, as the user is prob interested on the avg additional rewards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.