Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for UnaryMinus and UnaryPlus expressions #141

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

marcovtwout
Copy link
Contributor

Fixes #140

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@lisachenko
Copy link
Member

Hello, nice PR! Could you please also add a test somewhere for this, so it will be tested as well?

@marcovtwout
Copy link
Contributor Author

@lisachenko I implemented these in a similar fashion as the other resolveExpr functions in that class such as resolveExprBooleanNot(), but didn't find any tests for those in the test suite. I tested them manually, but if you have a suggestion on how to test these I'll write some tests.

@marcovtwout
Copy link
Contributor Author

@lisachenko Since there are no tests yet for the other features and this is still for the dev-version, perhaps merge this and create a seperate issue for adding tests?

@A-jay98
Copy link

A-jay98 commented Sep 23, 2024

@lisachenko Could you give an update regarding this issue? It would be great if you could merge this so that the current version of the library becomes useable again.

@lisachenko lisachenko merged commit 9c9bee0 into goaop:master Nov 25, 2024
4 checks passed
@lisachenko lisachenko changed the title Add support for UnaryMinus and UnaryPlus expressions [Feature] Add support for UnaryMinus and UnaryPlus expressions Nov 25, 2024
@lisachenko lisachenko added this to the 4.0.0 milestone Nov 25, 2024
@lisachenko
Copy link
Member

thx @marcovtwout 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ReflectionException "Could not find handler (..) resolveExprUnaryMinus method" for parameters like $foo-
4 participants