Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3494511: Profile image display twice on the post album page #4259

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

volodymyr-sydor
Copy link
Contributor

@volodymyr-sydor volodymyr-sydor commented Dec 17, 2024

Problem (for internal)

Looks like for now the current_user_image field is not available in the social_album_form_post_form_alter:
Screenshot

Additionally, after adding image, css class is not added that caused UI issue:
Screenshot 2024-12-19 at 14 44 09

Solution (for internal)

  • Replace social_album_form_post_form_alter with hux approach
  • Replace:
    $element_parents = \Drupal::request()->request->get('element_parents');
    with
    $element_parents = \Drupal::request()->query->get('element_parents');
    because now element_parents is under query:
Screenshot 2024-12-19 at 14 46 57

Release notes (to customers)

  • Fixed issues with duplicated profile image on the post album page
  • Fixed UI issues after adding images on the post album page

Issue tracker

Theme issue tracker

N/A

How to test

  • Using the latest version of Open Social with the social_album module enabled
  • As a sitemanager
  • Try to add images to existing album
  • When open "add image" page I expect that profile image located only in the right place.
  • The expected result is attained when repeating the steps with this fix applied.

Change Record

N/A

Translations

N/A

@volodymyr-sydor volodymyr-sydor added type: bug Fixes a bug in Open Social team: enterprise This PR originates from the ECI team status: needs work This pull request needs more work before it's ready for review prio: medium labels Dec 17, 2024
@volodymyr-sydor volodymyr-sydor added this to the 12.3.11 milestone Dec 17, 2024
@volodymyr-sydor volodymyr-sydor self-assigned this Dec 17, 2024
@volodymyr-sydor volodymyr-sydor force-pushed the bugfix/3494511-post-image branch from 247c53f to 0e71a5a Compare December 17, 2024 15:23
@volodymyr-sydor volodymyr-sydor changed the title Issue #3494511 by SV: Profile image display twice on the post album page Issue #3494511: Profile image display twice on the post album page Dec 17, 2024
@ribel ribel modified the milestones: 12.3.11, 13.0.0-alpha21 Dec 17, 2024
@volodymyr-sydor volodymyr-sydor force-pushed the bugfix/3494511-post-image branch from 0e71a5a to a7b8c20 Compare December 18, 2024 11:30
@volodymyr-sydor volodymyr-sydor added status: needs review This pull request is waiting for a requested review and removed status: needs work This pull request needs more work before it's ready for review labels Dec 20, 2024
@volodymyr-sydor volodymyr-sydor marked this pull request as ready for review December 20, 2024 12:02
@volodymyr-sydor volodymyr-sydor force-pushed the bugfix/3494511-post-image branch from 0f7e17b to 18471ef Compare December 20, 2024 12:33
@open-social-tugboat
Copy link

Tugboat has finished building the preview for this pull request!

Link:

Dashboard:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: bug Fixes a bug in Open Social
Development

Successfully merging this pull request may close these issues.

5 participants